Skip to content

Remove release plugin arguments from pom.xml and update workflows #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasturrell merged 5 commits into from
Nov 17, 2025
Merged

Remove release plugin arguments from pom.xml and update workflows #355

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5cab027
Initial plan
Copilot Nov 17, 2025
ae67957
Remove release plugin arguments from pom.xml and update workflows
Copilot Nov 17, 2025
a27f6cc
Simplify Maven commands by using -pl directly instead of -Darguments
Copilot Nov 17, 2025
5799f93
Use consistent -pl syntax in release:perform step
Copilot Nov 17, 2025
5ce642b
Merge branch 'main' into copilot/remove-release-plugin-arguments
thomasturrell Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/maven-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ jobs:
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
mvn -B -batch-mode release:prepare release:perform --file pom.xml
# Only release production modules, exclude all sample modules
mvn -B -batch-mode release:prepare release:perform --file pom.xml \
-Darguments="-pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am"
Comment thread
thomasturrell marked this conversation as resolved.
Outdated
env:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ jobs:
echo "Performing release and deploying to Maven Central"

# Run release:perform to build and deploy
# Only release production modules, exclude all sample modules
./mvnw -B release:perform \
-DlocalCheckout=true \
-DeployAtEnd=true
-DeployAtEnd=true \
-Darguments="-pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am"
Comment thread
thomasturrell marked this conversation as resolved.
Outdated
env:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
Expand Down
2 changes: 0 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,6 @@
<useReleaseProfile>false</useReleaseProfile>
<releaseProfiles>release</releaseProfiles>
<goals>deploy</goals>
<!-- Only release production modules, exclude all sample modules -->
<arguments>-pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am</arguments>
</configuration>
</plugin>
</plugins>
Expand Down