Skip to content

roles/dhcp: replace etcd locker with mutex#2175

Open
BeryJu wants to merge 2 commits intomainfrom
roles/dhcp/fix-etcd-mutex
Open

roles/dhcp: replace etcd locker with mutex#2175
BeryJu wants to merge 2 commits intomainfrom
roles/dhcp/fix-etcd-mutex

Conversation

@BeryJu
Copy link
Copy Markdown
Owner

@BeryJu BeryJu commented Apr 29, 2026

vibecoded btw

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit c21e1e7
🔍 Latest deploy log https://app.netlify.com/projects/beryju-gravity/deploys/69f7d405a124d100084006bc

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.36%. Comparing base (0e51f2f) to head (c21e1e7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dhcp/ipam_internal.go 57.89% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
- Coverage   69.42%   69.36%   -0.07%     
==========================================
  Files         138      138              
  Lines        7585     7599      +14     
==========================================
+ Hits         5266     5271       +5     
- Misses       1786     1793       +7     
- Partials      533      535       +2     
Flag Coverage Δ
bench 12.17% <57.89%> (+0.07%) ⬆️
e2e 45.29% <57.89%> (+<0.01%) ⬆️
unittest 55.38% <57.89%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant