Skip to content

fix: disable histogram polling after repeated failures#143

Merged
KIvanow merged 1 commit into
BetterDB-inc:masterfrom
100NikhilBro:fix/latency-histogram-failure
May 12, 2026
Merged

fix: disable histogram polling after repeated failures#143
KIvanow merged 1 commit into
BetterDB-inc:masterfrom
100NikhilBro:fix/latency-histogram-failure

Conversation

@100NikhilBro
Copy link
Copy Markdown
Contributor

Summary

Fix infinite error logging in latency histogram polling for unsupported Redis versions.

Changes

  • Added runtimeCapabilityTracker.recordFailure to histogram error handling
  • Aligns behavior with latency events handler
  • Disables polling after repeated failures

Result

Prevents continuous error logs for Redis/Valkey instances that do not support LATENCY HISTOGRAM.

Closes #43

@100NikhilBro
Copy link
Copy Markdown
Contributor Author

Hi @KIvanow , just a gentle follow-up on this PR.

All checks are passing, and I’ve kept the change aligned with the existing latency events handling pattern. Please let me know if any adjustments are needed.

Thanks for your time!

@100NikhilBro
Copy link
Copy Markdown
Contributor Author

Hi @KIvanow , just checking in once more on this PR whenever you get a chance.

No rush at all — I just wanted to see if there’s any feedback or changes needed from my side.

Thanks!

@KIvanow
Copy link
Copy Markdown
Member

KIvanow commented May 11, 2026

Hi @100NikhilBro, great catch! And thank you for the contribution!

Could you please sign your commit(s) and then I'll merge the PR.

@100NikhilBro 100NikhilBro force-pushed the fix/latency-histogram-failure branch from 69b0e25 to b29fddc Compare May 11, 2026 15:04
@100NikhilBro
Copy link
Copy Markdown
Contributor Author

Thanks! I’ve signed the commit and force-pushed the updated branch.

It looks like the current failing API test may be unrelated to this PR, since the changes here are limited to latency-analytics.service.ts. Happy to make any adjustments if needed.

@100NikhilBro 100NikhilBro force-pushed the fix/latency-histogram-failure branch from b29fddc to 988c229 Compare May 11, 2026 15:17
@KIvanow
Copy link
Copy Markdown
Member

KIvanow commented May 12, 2026

Thanks! I’ve signed the commit and force-pushed the updated branch.

It looks like the current failing API test may be unrelated to this PR, since the changes here are limited to latency-analytics.service.ts. Happy to make any adjustments if needed.

@100NikhilBro no worries on the API, that was a regression that I caused and fixed in a subsequent commit yesterday, but you synced in between. It's fixed on master/main

@KIvanow KIvanow merged commit 24616ca into BetterDB-inc:master May 12, 2026
1 of 3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

### Histogram errors log at ERROR level every poll cycle

2 participants