Split up verify & publish steps

Now we can verify prs or commits to other branches without attempting a
deploy

Author: prognostikos

.github/workflows/_build.yml

@@ -0,0 +1,37 @@
+name: Build Site
+
+on:
+  workflow_call:
+    outputs:
+      build-successful:
+        description: "Whether the build succeeded"
+        value: ${{ jobs.build.outputs.success }}
+
+jobs:
+  build:
+    name: Build Documentation Site
+    runs-on: ubuntu-latest
+    outputs:
+      success: ${{ steps.build.outcome == 'success' }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Ruby and install gems
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+        env:
+          BUNDLE_CACHE_PATH: "vendor/cache"
+
+      - name: Build site
+        id: build
+        run: |
+          bin/build
+
+      - name: Verify build artifacts exist
+        run: |
+          test -f build/index.html || (echo "build/index.html not found" && exit 1)
+          test -f source/schema.json || (echo "source/schema.json not found" && exit 1)
+          test -f source/includes/resources.md || (echo "source/includes/resources.md not found" && exit 1)
+          echo "All required build artifacts present"

.github/workflows/publish.yml

@@ -1,31 +1,47 @@
 name: Publish to developers.betternow.org
-on: [push]
+on:
+  push:
+    branches:
+      - master
+
 permissions:
   id-token: write
   contents: read
 
 jobs:
   build:
-    name: Build and Deploy
+    name: Build Documentation Site
+    uses: ./.github/workflows/_build.yml
+
+  deploy:
+    name: Deploy to S3
+    needs: build
     runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: read
     steps:
       - name: Checkout
         uses: actions/checkout@v2
+
       - name: Setup Ruby and install gems
         uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
         env:
           BUNDLE_CACHE_PATH: "vendor/cache"
+
       - name: Build site
         run: |
           bin/build
+
       - name: Configure AWS credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:
           role-to-assume: arn:aws:iam::357932486739:role/developer-docs-deployer
           role-session-name: deploydeveloperdocs
           aws-region: eu-west-1
+
       - name: Deploy the site
         run: |
           bin/deploy

.github/workflows/verify.yml

@@ -0,0 +1,11 @@
+name: Verify Build
+
+on:
+  push:
+    branches:
+      - '**'
+
+jobs:
+  verify:
+    name: Verify Documentation Build
+    uses: ./.github/workflows/_build.yml