Node-agent deferred init scan + OBI v0.6.0#124
Merged
Conversation
node-agent does an incredibly greedy scan on boot. this makes the caches fill up faster, at the cost of massive memory spike. also `init` holds all the data in memory by default until it's done. - new knob: `--init-scan=<enabled>|deferred|disabled` - new knob: `--init-scan-delay=<30s>` Plus a new batched init behavior with gc passes in between. By default does what upstream does. **When deferred**: - allows new containers to be discovered from ebpf immediately on boot, slowly expanding "known state" - after deferring for init-scan-delay seconds, runs batched init, filling caches carefully with gc passes Pros: lower moment-to-moment memory usage, reducing peak Cons: slower "full picture" (should still grab full state by about 60s since boot though) **When disabled**: - no walking /proc at all - memory impact _only_ from ebpf detections - possibly missing detections on non-networked processes I'm not aiming to use --init-scan=disabled, but I want to have it as an option. releasing new binaries comes with a time-to-adoption cost; I want the knob ready to go _if_ I ever need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initscan, reducing startup overhead🤖 Generated with Claude Code