Extract method for feature flag check#144
Open
stevenjackson wants to merge 1 commit into
Open
Conversation
While working on a controller we wanted a fallback behavior where we could check another related association for a test track assignment if the visitor did not have direct access. With this in place a controller can override the check when needed without completely replacing the before_action behavior ``` def feature_flagged?(feature_flag) super || current_user.organization.test_track_ab(feature_flag, context: self.class.name.underscore) end ```
Member
|
@smudge I think from a brief read of the ref'd retail PR discussion, this dips a toe into the zone that we want to address with parameterized splits a la split.io to get domain layer segmentation happening? Not sure whether this is a good thing to do til we're ready to bite that off or what, but your brain would be super helpful here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a controller we wanted a fallback behavior where we could check another related association for a test track assignment if the visitor did not have direct access.
With this in place a controller can override the check when needed without completely replacing the before_action behavior
/domain @Betterment/test_track_core
/platform @Betterment/test_track_core