Skip to content

Add RBI file for Sorbet type support#44

Open
jacamera wants to merge 4 commits into
Betterment:mainfrom
jacamera:jeffc/add-sorbet-annotation
Open

Add RBI file for Sorbet type support#44
jacamera wants to merge 4 commits into
Betterment:mainfrom
jacamera:jeffc/add-sorbet-annotation

Conversation

@jacamera
Copy link
Copy Markdown

@jacamera jacamera commented Mar 23, 2026

This PR adds an RBI file so that consumers of this gem that use Sorbet get full type support.

@jacamera jacamera marked this pull request as draft March 23, 2026 20:50
@jacamera jacamera changed the title added rbi Add Sorbet Support Mar 23, 2026
@jacamera jacamera changed the title Add Sorbet Support Add RBI file for Sorbet type support Mar 23, 2026
@jacamera jacamera marked this pull request as ready for review March 23, 2026 20:56
Comment thread Gemfile.lock
arm64-darwin-22
arm64-darwin-23
arm64-darwin-24
arm64-darwin-25
Copy link
Copy Markdown
Author

@jacamera jacamera Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want this. Got added when I ran bundle install after updating the VERSION constant.

frewsxcv
frewsxcv previously approved these changes Apr 7, 2026
Copy link
Copy Markdown

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

module WithTransactionalLock::Mixin::ClassMethods
sig do
type_parameters(:U)
.params(lock_name: String, block: T.proc.returns(T.type_parameter(:U)))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the lock_name could be anything that gets passed into this hashing function, but I would guess+hope that it's a string the vast majority of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants