Add RBI file for Sorbet type support#44
Open
jacamera wants to merge 4 commits into
Open
Conversation
jacamera
commented
Apr 7, 2026
| arm64-darwin-22 | ||
| arm64-darwin-23 | ||
| arm64-darwin-24 | ||
| arm64-darwin-25 |
Author
There was a problem hiding this comment.
Not sure if we want this. Got added when I ran bundle install after updating the VERSION constant.
frewsxcv
previously approved these changes
Apr 7, 2026
| module WithTransactionalLock::Mixin::ClassMethods | ||
| sig do | ||
| type_parameters(:U) | ||
| .params(lock_name: String, block: T.proc.returns(T.type_parameter(:U))) |
There was a problem hiding this comment.
Technically the lock_name could be anything that gets passed into this hashing function, but I would guess+hope that it's a string the vast majority of the time.
Invalidated by push of f29ec5c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an RBI file so that consumers of this gem that use Sorbet get full type support.