[improve][ci] Fixes apache#23079: Checkstyle checks applied to all test (apache#24492)

Author: Praveen7294

bouncy-castle/bcfips-include-test/src/test/java/org/apache/pulsar/client/TlsProducerConsumerBase.java

@@ -19,7 +19,6 @@
 package org.apache.pulsar.client;
 
 import static org.mockito.Mockito.spy;
-
 import com.google.common.collect.Sets;
 import java.util.HashMap;
 import java.util.Map;

bouncy-castle/bcfips-include-test/src/test/java/org/apache/pulsar/client/TlsProducerConsumerTest.java

@@ -34,16 +34,16 @@ public class TlsProducerConsumerTest extends TlsProducerConsumerBase {
 
     /**
      * verifies that messages whose size is larger than 2^14 bytes (max size of single TLS chunk) can be
-     * produced/consumed
+     * produced/consumed.
      *
      * @throws Exception
      */
     @Test(timeOut = 30000)
     public void testTlsLargeSizeMessage() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
-        final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size {} --", MESSAGE_SIZE);
+        final int messageSize = 16 * 1024 + 1;
+        log.info("-- message size {} --", messageSize);
 
         internalSetUpForClient(true, pulsar.getBrokerServiceUrlTls());
         internalSetUpForNamespace();
@@ -54,15 +54,15 @@ public void testTlsLargeSizeMessage() throws Exception {
         Producer<byte[]> producer = pulsarClient.newProducer().topic("persistent://my-property/use/my-ns/my-topic1")
                 .create();
         for (int i = 0; i < 10; i++) {
-            byte[] message = new byte[MESSAGE_SIZE];
+            byte[] message = new byte[messageSize];
             Arrays.fill(message, (byte) i);
             producer.send(message);
         }
 
         Message<byte[]> msg = null;
         for (int i = 0; i < 10; i++) {
             msg = consumer.receive(5, TimeUnit.SECONDS);
-            byte[] expected = new byte[MESSAGE_SIZE];
+            byte[] expected = new byte[messageSize];
             Arrays.fill(expected, (byte) i);
             Assert.assertEquals(expected, msg.getData());
         }
@@ -76,8 +76,8 @@ public void testTlsLargeSizeMessage() throws Exception {
     public void testTlsClientAuthOverBinaryProtocol() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
-        final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size {} --", MESSAGE_SIZE);
+        final int messageSize = 16 * 1024 + 1;
+        log.info("-- message size {} --", messageSize);
         internalSetUpForNamespace();
 
         // Test 1 - Using TLS on binary protocol without sending certs - expect failure
@@ -106,8 +106,8 @@ public void testTlsClientAuthOverBinaryProtocol() throws Exception {
     public void testTlsClientAuthOverHTTPProtocol() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
-        final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size {} --", MESSAGE_SIZE);
+        final int messageSize = 16 * 1024 + 1;
+        log.info("-- message size {} --", messageSize);
         internalSetUpForNamespace();
 
         // Test 1 - Using TLS on https without sending certs - expect failure

buildtools/src/main/resources/pulsar/suppressions.xml

@@ -37,8 +37,14 @@
     <suppress checks=".*" files=".+[\\/]generated-sources[\\/].+\.java"/>
     <suppress checks=".*" files=".+[\\/]generated-test-sources[\\/].+\.java"/>
 
-    <!-- suppress most all checks expect below-->
-    <suppress checks="^(?!.*(UnusedImports|IllegalImport)).*$" files=".*[\\/]src[\\/]test[\\/].*"/>
+   <!--  suppress LineLength due to usage of multi-line String with split function  -->
+   <suppress files="ExtensibleLoadManagerImplTest.java" checks="LineLength"/>
+   <suppress files="BundleSplitterTaskTest.java" checks="TodoComment"/>
+   <suppress files="BlobStoreTestBase.java" checks="TodoComment"/>
+   <suppress files="BlobStoreManagedLedgerOffloaderBase.java" checks="TodoComment"/>
+   <suppress files="DebeziumMsSqlSourceTester.java" checks="RegexpSinglelineJava"/>
+   <suppress files="DebeziumOracleDbSourceTester.java" checks="RegexpSinglelineJava"/>
+   <suppress files="PulsarIODebeziumSourceRunner.java" checks="RegexpSinglelineJava"/>
 
     <suppress checks="IllegalImport" files="ProxyServiceStarter.java"/>
 

buildtools/src/test/java/org/apache/pulsar/tests/BetweenTestClassesListenerAdapterTest.java

@@ -353,9 +353,9 @@ public void afterClass() {
 
         @Override
         public String toString() {
-            return "FactoryMethodCase{" +
-                    "id=" + id +
-                    '}';
+            return "FactoryMethodCase{"
+                    + "id=" + id
+                    + '}';
         }
     }
 
@@ -387,9 +387,9 @@ public void testWithDataProvider(int id) {
 
         @Override
         public String toString() {
-            return "FactoryMethodCaseWithoutAfterClass{" +
-                    "id=" + id +
-                    '}';
+            return "FactoryMethodCaseWithoutAfterClass{"
+                    + "id=" + id
+                    + '}';
         }
     }
 }

buildtools/src/test/java/org/apache/pulsar/tests/TestRetrySupportSuccessTest.java

@@ -24,7 +24,7 @@
 import org.testng.annotations.Test;
 
 /**
- * Tests that TestRetrySupport doesn't call setup & cleanup when tests are successful
+ * Tests that TestRetrySupport doesn't call setup & cleanup when tests are successful.
  */
 public class TestRetrySupportSuccessTest extends TestRetrySupport {
     private int setupCallCount;

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/EntryCacheManagerTest.java

@@ -20,19 +20,17 @@
 
 import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertTrue;
-
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.Random;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
-
 import lombok.Cleanup;
 import org.apache.bookkeeper.client.api.ReadHandle;
 import org.apache.bookkeeper.mledger.AsyncCallbacks;
@@ -397,7 +395,7 @@ void entryCacheDisabledAsyncReadEntry() throws Exception {
         when(ml1.getLastConfirmedEntry()).thenReturn(PositionFactory.create(1L, 1L));
         when(ml1.getOptionalLedgerInfo(lh.getId())).thenReturn(Optional.of(mock(
                 MLDataFormats.ManagedLedgerInfo.LedgerInfo.class)));
-        entryCache.asyncReadEntry(lh, PositionFactory.create(1L,1L), new AsyncCallbacks.ReadEntryCallback() {
+        entryCache.asyncReadEntry(lh, PositionFactory.create(1L, 1L), new AsyncCallbacks.ReadEntryCallback() {
             public void readEntryComplete(Entry entry, Object ctx) {
                 Assert.assertNotEquals(entry, null);
                 entry.release();

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/EntryCacheTest.java

@@ -27,7 +27,6 @@
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertNull;
 import static org.testng.Assert.assertTrue;
-
 import io.netty.buffer.Unpooled;
 import java.util.ArrayList;
 import java.util.List;

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/InflightReadsLimiterIntegrationTest.java

@@ -86,7 +86,7 @@ public void testPreciseLimitation(String missingCase) throws Exception {
         final RangeEntryCacheManagerImpl rangeEntryCacheManager =
                 (RangeEntryCacheManagerImpl) factory.getEntryCacheManager();
         final InflightReadsLimiter limiter = rangeEntryCacheManager.getInflightReadsLimiter();
-        final long totalCapacity =limiter.getRemainingBytes();
+        final long totalCapacity = limiter.getRemainingBytes();
         // final ManagedCursorImpl c1 = (ManagedCursorImpl) ml.openCursor("c1");
         for (byte i = 1; i < 127; i++) {
             log.info("add entry: " + i);
@@ -111,7 +111,7 @@ public void testPreciseLimitation(String missingCase) throws Exception {
                 readCompleteSignal1.await();
                 Object res = invocation.callRealMethod();
                 return res;
-            } else if(secondReadEntries.contains(firstEntry)) {
+            } else if (secondReadEntries.contains(firstEntry)) {
                 final CompletableFuture res = new CompletableFuture<>();
                 threadFactory.newThread(() -> {
                     try {

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorConcurrencyTest.java

@@ -21,9 +21,7 @@
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertNull;
-
 import com.google.common.collect.Lists;
-
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
@@ -135,7 +133,7 @@ public void testCloseAndRead() throws Exception {
 
         final ManagedCursor cursor = ledger.openCursor("c1");
         final CompletableFuture<String> closeFuture = new CompletableFuture<>();
-        final String CLOSED = "closed";
+        final String closed = "closed";
 
         final List<Position> addedEntries = new ArrayList();
 
@@ -182,7 +180,7 @@ public void testCloseAndRead() throws Exception {
                     @Override
                     public void closeComplete(Object ctx) {
                         log.info("Successfully closed cursor ledger");
-                        closeFuture.complete(CLOSED);
+                        closeFuture.complete(closed);
                     }
 
                     @Override
@@ -206,7 +204,7 @@ public void closeFailed(ManagedLedgerException exception, Object ctx) {
         counter.await();
 
         assertFalse(gotException.get());
-        assertEquals(closeFuture.get(), CLOSED);
+        assertEquals(closeFuture.get(), closed);
     }
 
     @Test(timeOut = 30000)
@@ -270,27 +268,27 @@ public void testConcurrentIndividualDeletes() throws Exception {
 
         final ManagedCursor cursor = ledger.openCursor("c1");
 
-        final int N = 1000;
-        final List<Position> addedEntries = Lists.newArrayListWithExpectedSize(N);
+        final int num = 1000;
+        final List<Position> addedEntries = Lists.newArrayListWithExpectedSize(num);
 
-        for (int i = 0; i < N; i++) {
+        for (int i = 0; i < num; i++) {
             Position pos = ledger.addEntry("entry".getBytes());
             addedEntries.add(pos);
         }
 
-        final int Threads = 10;
-        final CyclicBarrier barrier = new CyclicBarrier(Threads);
-        final CountDownLatch counter = new CountDownLatch(Threads);
+        final int threads = 10;
+        final CyclicBarrier barrier = new CyclicBarrier(threads);
+        final CountDownLatch counter = new CountDownLatch(threads);
         final AtomicBoolean gotException = new AtomicBoolean(false);
 
-        for (int thread = 0; thread < Threads; thread++) {
+        for (int thread = 0; thread < threads; thread++) {
             final int myThread = thread;
             cachedExecutor.execute(() -> {
                 try {
                     barrier.await();
 
-                    for (int i = 0; i < N; i++) {
-                        int threadId = i % Threads;
+                    for (int i = 0; i < num; i++) {
+                        int threadId = i % threads;
                         if (threadId == myThread) {
                             cursor.delete(addedEntries.get(i));
                         }
@@ -321,8 +319,8 @@ public void testConcurrentReadOfSameEntry() throws Exception {
             cursors.add(cursor);
         }
 
-        final int N = 100;
-        for (int i = 0; i < N; i++) {
+        final int num = 100;
+        for (int i = 0; i < num; i++) {
             ledger.addEntry(("entry" + i).getBytes());
         }
         long currentLedger = cursors.get(0).getMarkDeletedPosition().getLedgerId();
@@ -341,7 +339,7 @@ public void testConcurrentReadOfSameEntry() throws Exception {
             cachedExecutor.execute(() -> {
                 try {
                     barrier.await();
-                    for (int j = 0; j < N; j++) {
+                    for (int j = 0; j < num; j++) {
                         String expected = "entry" + j;
                         String data = new String(cursor.readEntries(1).get(0).getDataAndRelease());
                         if ((!expected.equals(data)) && result.get() == null) {
@@ -368,10 +366,10 @@ public void testConcurrentIndividualDeletesWithGetNthEntry() throws Exception {
 
         final ManagedCursor cursor = ledger.openCursor("c1");
 
-        final int N = 1000;
-        final List<Position> addedEntries = Lists.newArrayListWithExpectedSize(N);
+        final int num = 1000;
+        final List<Position> addedEntries = Lists.newArrayListWithExpectedSize(num);
 
-        for (int i = 0; i < N; i++) {
+        for (int i = 0; i < num; i++) {
             Position pos = ledger.addEntry("entry".getBytes());
             addedEntries.add(pos);
         }
@@ -407,7 +405,7 @@ public void deleteFailed(ManagedLedgerException exception, Object ctx) {
 
         counter.await();
 
-        final int readEntries = N - deleteEntries;
+        final int readEntries = num - deleteEntries;
         final CountDownLatch readCounter = new CountDownLatch(readEntries);
         final AtomicInteger successReadEntries = new AtomicInteger(0);
         for (int i = 1; i <= readEntries; i++) {

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainerTest.java

@@ -290,12 +290,14 @@ public List<Entry> replayEntries(Set<? extends Position> positions) {
         }
 
         @Override
-        public Set<? extends Position> asyncReplayEntries(Set<? extends Position> positions, ReadEntriesCallback callback, Object ctx) {
+        public Set<? extends Position> asyncReplayEntries(Set<? extends Position> positions,
+                                                        ReadEntriesCallback callback, Object ctx) {
             return Sets.newConcurrentHashSet();
         }
 
         @Override
-        public Set<? extends Position> asyncReplayEntries(Set<? extends Position> positions, ReadEntriesCallback callback, Object ctx, boolean sortEntries) {
+        public Set<? extends Position> asyncReplayEntries(Set<? extends Position> positions,
+                                                        ReadEntriesCallback callback, Object ctx, boolean sortEntries) {
             return Sets.newConcurrentHashSet();
         }
 
@@ -321,12 +323,12 @@ public boolean cancelPendingReadRequest() {
         }
 
         @Override
-        public Entry getNthEntry(int N, IndividualDeletedEntries deletedEntries) {
+        public Entry getNthEntry(int num, IndividualDeletedEntries deletedEntries) {
             return null;
         }
 
         @Override
-        public void asyncGetNthEntry(int N, IndividualDeletedEntries deletedEntries, ReadEntryCallback callback,
+        public void asyncGetNthEntry(int num, IndividualDeletedEntries deletedEntries, ReadEntryCallback callback,
                 Object ctx) {
         }
 
@@ -449,29 +451,29 @@ public void testSlowestReadPositionForActiveCursors() {
         assertNull(container.getSlowestReaderPosition());
 
         // Add no durable cursor
-        Position position = PositionFactory.create(5,5);
+        Position position = PositionFactory.create(5, 5);
         ManagedCursor cursor1 = spy(new MockManagedCursor(container, "test1", position));
         doReturn(false).when(cursor1).isDurable();
         doReturn(position).when(cursor1).getReadPosition();
         container.add(cursor1, position);
         assertEquals(container.getSlowestReaderPosition(), PositionFactory.create(5, 5));
 
         // Add no durable cursor
-        position = PositionFactory.create(1,1);
+        position = PositionFactory.create(1, 1);
         ManagedCursor cursor2 = spy(new MockManagedCursor(container, "test2", position));
         doReturn(false).when(cursor2).isDurable();
         doReturn(position).when(cursor2).getReadPosition();
         container.add(cursor2, position);
         assertEquals(container.getSlowestReaderPosition(), PositionFactory.create(1, 1));
 
         // Move forward cursor, cursor1 = 5:5, cursor2 = 5:6, slowest is 5:5
-        position = PositionFactory.create(5,6);
+        position = PositionFactory.create(5, 6);
         container.cursorUpdated(cursor2, position);
         doReturn(position).when(cursor2).getReadPosition();
         assertEquals(container.getSlowestReaderPosition(), PositionFactory.create(5, 5));
 
         // Move forward cursor, cursor1 = 5:8, cursor2 = 5:6, slowest is 5:6
-        position = PositionFactory.create(5,8);
+        position = PositionFactory.create(5, 8);
         doReturn(position).when(cursor1).getReadPosition();
         container.cursorUpdated(cursor1, position);
         assertEquals(container.getSlowestReaderPosition(), PositionFactory.create(5, 6));