[fix][broker] Use poll instead remove to avoid NoSuchElementException (apache#24933)

Technoboy- · web-flow · commit 402ed5bc0a50 · 2025-11-03T18:53:59.000+08:00
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java b/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java
@@ -218,7 +218,10 @@ protected CompletableFuture<Void> failPendingReceive() {
         private void failPendingRawReceives() {
             List<CompletableFuture<RawMessage>> toError = new ArrayList<>();
             while (!pendingRawReceives.isEmpty()) {
-                toError.add(pendingRawReceives.remove());
+                final CompletableFuture<RawMessage> ret = pendingRawReceives.poll();
+                if (ret != null) {
+                    toError.add(ret);
+                }
             }
             toError.forEach((f) -> f.cancel(false));
         }

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,10 @@ protected CompletableFuture<Void> failPendingReceive() {`
`218`	`218`	`private void failPendingRawReceives() {`
`219`	`219`	`List<CompletableFuture<RawMessage>> toError = new ArrayList<>();`
`220`	`220`	`while (!pendingRawReceives.isEmpty()) {`
`221`		`- toError.add(pendingRawReceives.remove());`
	`221`	`+ final CompletableFuture<RawMessage> ret = pendingRawReceives.poll();`
	`222`	`+ if (ret != null) {`
	`223`	`+ toError.add(ret);`
	`224`	`+ }`
`222`	`225`	`}`
`223`	`226`	`toError.forEach((f) -> f.cancel(false));`
`224`	`227`	`}`