[fix][client] Move MessageIdAdv to the pulsar-common module#27
Closed
BewareMyPower wants to merge 2 commits into
Closed
[fix][client] Move MessageIdAdv to the pulsar-common module#27BewareMyPower wants to merge 2 commits into
BewareMyPower wants to merge 2 commits into
Conversation
BewareMyPower
force-pushed
the
bewaremypower/pip-229-module-change
branch
from
32b171a to
7be139d
Compare
### Motivation apache#19414 does not follow the design of apache#18950 > Since the aimed developers are Pulsar core developers, it's added in > the pulsar-common module (PulsarApi.proto is also in this module), not > the pulsar-client-api module. The reason is that `TopicMessageId#create` now cannot be a `MessageIdAdv` if `MessageIdAdv` is not in the `pulsar-client-api` module. ### Modifications - Move the `MessageIdAdv` class to the `pulsar-common` module. - Implement the `MessageIdAdv` interface in `TopicMessageIdImpl` instead of `TopicMessageId.Impl`. - Create a `TopicMessageIdImpl` instance for `TopicMessageId#create` via the `DefaultImplementation` class with the overhead of reflection.
BewareMyPower
force-pushed
the
bewaremypower/pip-229-module-change
branch
from
ed21ed3 to
26a5ec6
Compare
14 tasks
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage ? 72.94%
Complexity ? 31934
=========================================
Files ? 1868
Lines ? 138417
Branches ? 15236
=========================================
Hits ? 100972
Misses ? 29409
Partials ? 8036
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
The pr had no activity for 30 days, mark with Stale label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
apache#19414 does not follow the design of apache#18950
The reason is that
TopicMessageId#createnow cannot be aMessageIdAdvifMessageIdAdvis not in thepulsar-client-apimodule.Modifications
MessageIdAdvclass to thepulsar-commonmodule.TopicMessageIdwell, addMessageIdAdvUtils#convertto add an extra deserialization and serialization ofMessageId.