refactor: update redeem code logic for auto-public and storage constraints

- Only store successful or expired redeems in database (invalid codes not stored)
- Auto-make codes public when second user successfully redeems same code
- Remove /redeempublic command - public codes redeemed via /redeem
- Remove public code auto-redemption from /setup
- Add safeguard: explicitly public codes revert to private if they become invalid
- Add helper methods: isCodePublic(), isCodeSuccessfullyRedeemedByOther(), markCodeAsPrivate()
- Update all documentation and command references

Author: BigMichi1

.instructions.md

@@ -211,13 +211,12 @@ export async function execute(interaction: ChatInputCommandInteraction) {
 
 **Credential Management**
 
-- `/setup` - Save Idle Champions credentials (auto-redeems public codes for new users)
+- `/setup` - Save Idle Champions credentials
 
 **Code Redemption**
 
-- `/redeem` - Privately redeem a code (private to you)
-- `/redeempublic` - Publicly redeem shared codes (shows available codes or redeems specific one)
-- `/makepublic` - Share your redeemed code with other users
+- `/redeem` - Redeem a code (private by default, becomes public if another user redeems successfully)
+- `/makepublic` - Explicitly share your redeemed code with other users
 
 **Account Management**
 
@@ -318,14 +317,23 @@ const details = await codeManager.getRedeemedCodeDetails(discordId, limit);
 **Public Code Management**
 
 ```typescript
-// Get all public unexpired codes (for /redeempublic)
+// Get all public unexpired codes
 const publicCodes = await codeManager.getPublicUnexpiredCodes();
 
+// Check if code is public
+const isPublic = await codeManager.isCodePublic(code);
+
+// Check if code was successfully redeemed by another user
+const redeemedByOther = await codeManager.isCodeSuccessfullyRedeemedByOther(code, userId);
+
 // Mark code as expired (called when server returns "expired" error)
 await codeManager.markCodeAsExpired(code);
 
 // Make a code public (called by /makepublic command)
 await codeManager.markCodeAsPublic(code);
+
+// Make a code private (called when an explicitly public code becomes invalid on redeem)
+await codeManager.markCodeAsPrivate(code);
 ```
 
 ### Adding Data
@@ -335,7 +343,7 @@ await codeManager.markCodeAsPublic(code);
 await codeManager.addRedeemedCode(
   code,
   interaction.user.id,
-  'success',
+  'Success',
   lootDetails,
   false // Private
 );
@@ -693,44 +701,39 @@ NODE_ENV=development           # Optional
 
 ### Public vs Private Codes
 
-The bot now supports sharing codes between users:
+The bot supports automatic and manual code sharing between users:
 
 **Private Codes** (Default)
 
-- Redeemed via `/redeem` command
+- All codes start as private when redeemed via `/redeem`
 - Only the user who redeemed it gets the rewards
-- Not shared with other users
-- Stored in database for user's history
+- Not shared with other users unless explicitly made public
+- **Auto-Public on Second User Success**: If a second user successfully redeems the same code, it automatically becomes public for both users
 
-**Public Codes**
+**Public Codes** (Explicit or Automatic)
 
-- Made public via `/makepublic` command
-- Any user can redeem via `/redeempublic`
-- Only unexpired, successful codes can be made public
-- When new users run `/setup`, public codes are automatically redeemed for them
+- Made public automatically when a second user successfully redeems it
+- Made public explicitly via `/makepublic` command
+- Any user can redeem public codes via `/redeem` command
+- If an explicitly public code becomes invalid on redemption, it's automatically switched back to private (may be a mistake)
+- Only unexpired, successful codes show as public
 
 ### Workflow Example
 
-1. User A redeems code `XYZ` via `/redeem code:XYZ` (private)
-2. User A likes the code and runs `/makepublic code:XYZ` to share it
-3. User B joins and runs `/setup` → automatically redeems `XYZ` and gets rewards
-4. User C can manually redeem via `/redeempublic code:XYZ` to see and redeem the shared code
-5. User D can run `/redeempublic` (no code) to see all available public codes
-
-### Expiration Tracking
-
-Codes can expire on the game server:
-
-- When a code fails to redeem with "expired" error message, bot marks it as `expired`
-- Expired codes no longer appear in public code lists
-- Each code tracks when it expires via `expires_at` timestamp
+1. User A redeems code `XYZ` via `/redeem code:XYZ` (stored as private)
+2. User B redeems the same code `XYZ` via `/redeem code:XYZ` → code automatically becomes public
+3. User A can see the code is now public in `/codes` command
+4. User C can manually redeem via `/redeem code:XYZ` and will also see it as public
+5. User A can explicitly make a code public via `/makepublic code:XYZ` (for exclusive codes they want to share)
+6. If User D redeems an explicitly public code and it becomes invalid, it switches back to private automatically
 
 ### Database Fields
 
-**redeemed_codes table additions:**
+**redeemed_codes table fields:**
 
 - `is_public` (integer) - 1 if public, 0 if private
 - `expires_at` (datetime) - When code expires (null = never)
+- `status` (text) - 'Success' or 'Code Expired' (only successful/expired redeems are stored)
 
 ## Code Scanning (Auto-detection)
 

README.md

@@ -63,7 +63,7 @@ See [docker-compose.example.yml](docker-compose.example.yml) for all available c
 
 ## ✨ Features
 
-- 🤖 **Slash Commands** - `/setup`, `/redeem`, `/inventory`, `/open`, `/blacksmith`, `/codes`, `/makepublic`, `/redeempublic`, `/help`
+- 🤖 **Slash Commands** - `/setup`, `/redeem`, `/inventory`, `/open`, `/blacksmith`, `/codes`, `/makepublic`, `/help`
 - 🔄 **Auto Code Detection** - Scans Discord messages for codes automatically
 - 🎁 **Code Redemption** - Submit codes and get rewards
 - 📦 **Chest Management** - Open chests and view loot

docs/README.md

@@ -4,7 +4,7 @@ A Discord bot that automatically scans for and redeems Idle Champions promo code
 
 ## Features
 
-- 🤖 **Slash Commands** - `/setup`, `/redeem`, `/inventory`, `/open`, `/blacksmith`, `/codes`, `/makepublic`, `/redeempublic`, `/help`
+- 🤖 **Slash Commands** - `/setup`, `/redeem`, `/inventory`, `/open`, `/blacksmith`, `/codes`, `/makepublic`, `/help`
 - 🔄 **Auto Code Detection** - Scans Discord messages for codes automatically
 - 🎁 **Code Redemption** - Submit codes and get rewards
 - 📦 **Chest Management** - Open chests and view loot
@@ -62,7 +62,6 @@ brew install mise
 | `/blacksmith contract_type:<type> hero_id:<id> count:<count>` | Upgrade heroes                                        |
 | `/codes [count:<count>]`                                      | Show your redeemed codes history (last 10)            |
 | `/makepublic code:<code>`                                     | Share one of your redeemed codes with other users     |
-| `/redeempublic [code:<code>]`                                 | Redeem public codes shared by other users             |
 | `/help`                                                       | Show all commands                                     |
 
 ### Setup & Authentication
@@ -88,15 +87,6 @@ Manually redeem a single code and immediately receive rewards.
 - **Response:** Shows rewards obtained (gold, rubies, chests, etc.)
 - **Example:** `/redeem code:IDLE2024`
 
-#### `/redeempublic [code:<code>]`
-
-Redeem public codes that other users have shared. Leave the code empty to see all available shared codes, or specify a code to redeem it directly.
-
-- **Optional parameters:**
-  - `code` - Specific code to redeem (if empty, shows available codes)
-- **Benefits:** Access codes from community members who used `/makepublic`
-- **Example:** `/redeempublic` or `/redeempublic code:SHARED123`
-
 ### Inventory & Progress
 
 #### `/inventory`
@@ -144,11 +134,12 @@ View your personal code redemption history.
 
 #### `/makepublic code:<code>`
 
-Share one of your previously redeemed codes with other users. They can then use it with `/redeempublic`.
+Share one of your previously redeemed codes with other users. Other users can redeem the same code via `/redeem` and the rewards will be shared.
 
 - **Required parameters:**
   - `code` - One of your redeemed codes (must be in your history)
 - **Requirement:** You must have already redeemed this code
+- **Note:** Codes automatically become public when a second user successfully redeems them
 - **Example:** `/makepublic code:SHARED123`
 
 ### Help

docs/STRUCTURE.md

@@ -56,7 +56,7 @@ idle-code-redeemer/
 - **[src/bot/bot.ts](../src/bot/bot.ts)** - Discord client initialization, event handlers, command routing
 - **[src/bot/api/idleChampionsApi.ts](../src/bot/api/idleChampionsApi.ts)** - Game server API client with query-parameter format
 
-### Commands (9 slash commands)
+### Commands (8 slash commands)
 
 - **[src/bot/commands/setup.ts](../src/bot/commands/setup.ts)** - `/setup user_id:<id> user_hash:<hash>`
 - **[src/bot/commands/redeem.ts](../src/bot/commands/redeem.ts)** - `/redeem code:<code>`
@@ -65,7 +65,6 @@ idle-code-redeemer/
 - **[src/bot/commands/blacksmith.ts](../src/bot/commands/blacksmith.ts)** - `/blacksmith contract_type:<type> hero_id:<id> count:<count>`
 - **[src/bot/commands/codes.ts](../src/bot/commands/codes.ts)** - `/codes [count:<count>]` (view redeemed codes history)
 - **[src/bot/commands/makepublic.ts](../src/bot/commands/makepublic.ts)** - `/makepublic code:<code>` (share codes with other users)
-- **[src/bot/commands/redeempublic.ts](../src/bot/commands/redeempublic.ts)** - `/redeempublic [code:<code>]` (redeem shared codes)
 - **[src/bot/commands/help.ts](../src/bot/commands/help.ts)** - `/help`
 
 ### Database

src/bot/commands/makepublic.ts

@@ -40,7 +40,7 @@ export async function execute(interaction: ChatInputCommandInteraction) {
       .setColor(0x00ff00)
       .setTitle('✅ Code Shared Successfully')
       .setDescription(
-        `The code \`${code}\` is now public!\n\nOther users can now redeem it using \`/redeempublic code:${code}\``
+        `The code \`${code}\` is now public!\n\nOther users can now redeem it using \`/redeem code:${code}\``
       )
       .setFooter({ text: 'Public codes are shared with all server members' });
 

src/bot/commands/redeem.ts

@@ -154,22 +154,55 @@ export async function execute(interaction: ChatInputCommandInteraction) {
       return;
     }
 
-    // Save to database (private code)
     const codeResponse = response as any;
     const statusName = getCodeStatusName(codeResponse.codeStatus);
+    const isSuccess = codeResponse.codeStatus === 0; // 0 = Success
+    const isExpiredStatus = codeResponse.codeStatus === 4; // 4 = Code Expired
+
     logger.info(
       `[REDEEM] Code ${code} redeemed with status: ${statusName} for user ${interaction.user.tag}`
     );
-    await codeManager.addRedeemedCode(
-      code,
-      interaction.user.id,
-      statusName,
-      codeResponse.lootDetail,
-      false // Private code
-    );
+
+    // Only store successful or expired redeems
+    if (isSuccess || isExpiredStatus) {
+      let shouldBePublic = false;
+
+      // If successful, check if another user already successfully redeemed it
+      if (isSuccess) {
+        const wasRedeemedByOther = await codeManager.isCodeSuccessfullyRedeemedByOther(
+          code,
+          interaction.user.id
+        );
+        if (wasRedeemedByOther) {
+          // Second user redeeming successfully - make it public
+          shouldBePublic = true;
+          logger.info(
+            `[REDEEM] Code ${code} will be auto-made public (second successful redeem)`
+          );
+        }
+      }
+
+      await codeManager.addRedeemedCode(
+        code,
+        interaction.user.id,
+        statusName,
+        codeResponse.lootDetail,
+        shouldBePublic // Private by default, public if second user redeems successfully
+      );
+    } else {
+      // For invalid/already redeemed codes - check if the code was explicitly made public
+      // If so, switch it back to private (might be a mistake)
+      const codeWasPublic = await codeManager.isCodePublic(code);
+
+      if (codeWasPublic) {
+        logger.warn(
+          `[REDEEM] Code ${code} was public but is now invalid - switching back to private`
+        );
+        await codeManager.markCodeAsPrivate(code);
+      }
+    }
 
     // Build response embed
-    const isSuccess = codeResponse.codeStatus === 0; // 0 = Success
     const embed = new EmbedBuilder()
       .setColor(isSuccess ? 0x00ff00 : 0xffaa00)
       .setTitle(isSuccess ? '✅ Code Redeemed!' : `⚠️ ${statusName}`)