test: cover parseLootEntries catch block for malformed JSON

Add a backfillLootTotals test that inserts a row with invalid JSON in
lootDetail so the JSON.parse catch branch in parseLootEntries is
exercised, restoring 100% line coverage on codeManager.ts.

Signed-off-by: Michael Cramer <michael@bigmichi1.de>

Author: BigMichi1

src/bot/database/codeManager.test.ts

@@ -794,4 +794,15 @@ describe('backfillLootTotals', () => {
     expect(loot.chests).toEqual({});
     expect(loot.items).toEqual({});
   });
+
+  test('skips rows with malformed JSON loot detail', async () => {
+    db.insert(redeemedCodes)
+      .values({ code: 'CODE1111AAAA', discordId: USER_A, status: 'Success', lootDetail: 'not-valid-json{' })
+      .run();
+    await codeManager.backfillLootTotals();
+    const loot = await codeManager.getAggregateLoot(USER_A);
+    expect(loot.chests).toEqual({});
+    expect(loot.items).toEqual({});
+  });
 });
+

src/bot/database/codeManager.ts

@@ -71,7 +71,7 @@ class CodeManager {
     isPublic: boolean = false
   ): Promise<void> {
     const normalizedStatus = normalizeCodeStatus(status);
-    const lootStr = lootDetail !== null && lootDetail !== undefined ? JSON.stringify(lootDetail) : null;
+    const lootStr = lootDetail !== undefined ? JSON.stringify(lootDetail) : null;
     db.insert(redeemedCodes)
       .values({
         code,