refactor: move src/lib types to src/bot/api/types, add missing tests#33
Merged
Conversation
Signed-off-by: Michael Cramer <michael@bigmichi1.de>
There was a problem hiding this comment.
Pull request overview
This PR moves Idle Champions API declaration types from src/lib into src/bot/api/types and expands test coverage for database, scanner, and API request logging utilities.
Changes:
- Updated API type reference paths and Docker/ESLint configuration for the new type location.
- Added declaration files under
src/bot/api/types. - Added tests for backfill management, code scanning, code manager helpers, and API request logging.
Reviewed changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Dockerfile |
Stops copying removed src/lib into the build context. |
eslint.config.mjs |
Ignores the relocated generated API type declarations. |
src/bot/api/idleChampionsApi.ts |
Points triple-slash references to src/bot/api/types. |
src/bot/api/types/blacksmith_response.d.ts |
Adds relocated blacksmith API response types. |
src/bot/api/types/player_data.d.ts |
Adds relocated player data API response types. |
src/bot/api/types/redeem_code_response.d.ts |
Adds relocated redemption/chest API response types. |
src/bot/api/types/server_definitions.d.ts |
Adds relocated server definition response types. |
src/bot/database/backfillManager.test.ts |
Adds tests for backfill lifecycle and query helpers. |
src/bot/database/codeManager.test.ts |
Adds tests for redeemed/public code helper methods. |
src/bot/handlers/codeScanner.test.ts |
Adds DB-backed tests for scanning messages for new codes. |
src/bot/utils/apiRequestLogger.test.ts |
Adds tests for request log writing and reading behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Cramer <michael@bigmichi1.de>
✅ Coverage Report
New Files
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.