fix: catchup shows no codes after startup backfill

[BigMichi1]

Problem

Users who registered via /setup after the bot started were seeing "ℹ️ No Codes Available" when running /catchup, even though the startup backfill had found codes.

Three separate bugs caused this:

---

Bug 1 — Pending codes were never saved to the database

backfillHandler.ts incremented stats.pendingCodes but never called codeManager.addPendingCode(). The codes existed only in memory, so /catchup (which reads from the database) found nothing.

Fix: Added await codeManager.addPendingCode(code) in the trailing loop that processes unredeemed codes.

---

Bug 2 — All user redemptions during backfill were silently skipped

backfillHandler.ts checked 'success' in userDetailsResponse to validate the API response. Valid PlayerData objects never have a success property (they have details), so the condition was always false. Every user's redemption attempt was logged as "not a valid response" and skipped.

Fix: Changed the check to !playerData?.details.

---

Bug 3 — Multiple missing codeManager methods

Several methods called by production commands and tests were never implemented:

• normalizeCodeStatus — converts numeric API status codes to canonical strings
• isCodeRedeemedByUser — checks if a specific user redeemed a code
• getAllValidCodes — used by /catchup to find redeemable codes
• addNewPendingCodes — bulk insert, returns only newly added codes
• getRedeemedCodeCount — count of redemptions for a user
• deleteUserRedeemedCodes — used by /deleteaccount
• getRedeemedCodesByUsers — bulk lookup for the auto-redeemer
• getServerCodeStats — used by /stats
• getAggregateLoot — now backed by the loot_totals table
• backfillLootTotals — one-time migration to seed loot_totals

Also fixed:

• addRedeemedCode: status normalization, correct onConflictDoUpdate target ([code, discordId]), proper isPublic propagation, writes loot to loot_totals on Success
• addPendingCode: added onConflictDoNothing() to make it idempotent
• getRedeemedCodeDetails: added optional offset parameter

---

Testing

Added src/bot/handlers/backfillHandler.test.ts with 6 end-to-end tests covering:

• Startup backfill with no registered users → codes stored as pending → new user /catchup works
• API failure during backfill falls back to storing codes as pending
• Duplicate backfill runs are idempotent

All 270 tests across 10 files pass.

[Copilot]

Pull request overview

Fixes /catchup returning “No Codes Available” after startup backfill by ensuring backfill persists pending codes, correctly validates getUserDetails responses, and fills in missing/incorrect codeManager behaviors relied on by commands and background jobs.

Changes:

• Persist unredeemed backfill-discovered codes into pending_codes so /catchup can redeem them later.
• Correct backfill API response validation to detect valid PlayerData responses via the details shape.
• Add/adjust codeManager methods (status normalization, pending/redeemed lookups, valid-code listing, loot totals backfill) and add E2E backfill regression tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/bot/handlers/backfillHandler.ts	Fixes backfill user-details validation and persists unredeemed codes as pending.
src/bot/handlers/backfillHandler.test.ts	Adds end-to-end regression tests covering startup backfill → setup → catchup and idempotency.
src/bot/database/codeManager.ts	Implements/adjusts code status normalization, pending/redeemed queries, bulk operations, and loot totals logic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

✅ Coverage Report

Metric	Value
Current coverage	70.53% (1544/2189)
Baseline coverage	68.75% (1355/1971)
Result	PASS

New Files

File	Coverage	Lines	Status
src/bot/handlers/backfillHandler.test.ts	—	—	SKIP (ignored)

Changed Files

File	Baseline	Current	Status
src/bot/database/codeManager.test.ts	—	—	SKIP (ignored)
src/bot/database/codeManager.ts	100.00%	100.00%	PASS
src/bot/handlers/backfillHandler.ts	N/A	N/A	SKIP (new to coverage)

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/bot/handlers/backfillHandler.ts:252

• stats.pendingCodes is set to inserted.length, which only counts newly-inserted pending codes. If some codes were already present in pending_codes (e.g., repeated backfills), the progress message will under-report how many codes are pending/available. If the intent is “pending codes found this run”, consider using codesToPend.length; if the intent is “newly inserted”, consider adjusting the label/message accordingly.

    const redeemedSet = await codeManager.getRedeemedCodesFromList(allCodesArr);
    const codesToPend = allCodesArr.filter((c) => !redeemedSet.has(c));
    const inserted = await codeManager.addNewPendingCodes(codesToPend);
    stats.pendingCodes = inserted.length;

    onProgress?.(
      `✅ Backfill complete! Found: ${stats.codesFound}, Redeemed: ${stats.codesRedeemed}, Pending: ${stats.pendingCodes}`
    );

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.