'New' X11 port : found/worked around remaining X11 memory leaks. Updated docs for this port, and incremented version month/day.

Author: Bill-Gray

curses.h

@@ -40,9 +40,9 @@ Defined by this header:
 #define PDC_VER_MAJOR    4
 #define PDC_VER_MINOR    5
 #define PDC_VER_CHANGE   0
-#define PDC_VER_YEAR   2024
-#define PDC_VER_MONTH    12
-#define PDC_VER_DAY      31
+#define PDC_VER_YEAR   2025
+#define PDC_VER_MONTH     3
+#define PDC_VER_DAY      26
 
 #define PDC_STRINGIZE( x) #x
 #define PDC_stringize( x) PDC_STRINGIZE( x)

x11new/README.md

@@ -1,7 +1,7 @@
-PDCurses for X11 (new,  experimental)
-=====================================
+PDCursesMod for X11 (new,  experimental)
+========================================
 
-This port of PDCurses for X11 has been written from scratch,  with
+This port of PDCursesMod for X11 has been written from scratch,  with
 (thus far) only the key remapping array taken from pdckbd.c of the
 "original" X11 port.  It is,  as yet,  unclear if this will be a
 replacement for the original port.  As noted in the 'to do' section,
@@ -12,31 +12,31 @@ Building
 --------
 
 - Run "make".  Add UTF8=Y to force the wide-character version.  Add
-  DEBUG=Y for the debug version.  Add the target "demos" to build
-  the sample programs,  and/or "tests" for the test programs.
+  DEBUG=Y for the debug version.  Add NO_LEAKS=Y to avoid Xlib's tendency
+  to leak lots of memory (this does limit you to a US keyboard;  see
+  pdckbd.c.)  Add the target "demos" to build the sample programs,
+  and/or "tests" for the test programs.
 
 - Currently,  there is no "make install".
 
 Usage
 -----
 
 When compiling your application, you need to include the \<curses.h\>
-that comes with PDCurses. You also need to link your code with
+that comes with PDCursesMod. You also need to link your code with
 libXCurses. You will need to link with the following libraries:
 
    -lX11 -lpthread
 
 To do
 -----
 
-- Add mouse handling
+- Add mouse wheel handling
 - Combining and fullwidth characters
 - How to do SMB (Unicode > 0xffff)?
-- Blinking text
 - Under/over/strikeout/left/right lines
 - Bold & italic text
 - Respond to Ctrl-plus and Ctrl-minus with font size changes?
-- Programmatic resizing?
 
 Most of these shouldn't be all that tough to do.
 
@@ -45,7 +45,7 @@ Interaction with stdio
 
 Be aware that curses programs that expect to have a normal tty
 underneath them will be very disappointed! Output directed to stdout
-will go to the xterm that invoked the PDCurses application, or to the
+will go to the xterm that invoked the PDCursesMod application, or to the
 console if not invoked directly from an xterm. Similarly, stdin will
 expect its input from the same place as stdout.
 

x11new/pdckbd.c

@@ -297,9 +297,9 @@ static struct
 attempt to clean up all allocations,  this can be a significant problem;  the
 memory you leak will be overwhelmed by hundreds of small allocations that
 Xlib neglects to free.  Almost all of these allocations are in XIM (X Input
-Methods).  Compile with -DNO_LEAKS,  and XIM will not be used,  and most
-of the memory will be correctly freed,  making it _much_ easier to see any
-mistakes you've made.
+Methods),  plus a couple in the font code (see pdcscrn.c).  Compile with
+-DNO_LEAKS,  and XIM will not be used,  and memory should be correctly freed,
+making it _much_ easier to see any mistakes you've made.
 
    Unfortunately,  without XIM,  some keyboard input will not be correctly
 translated,  and a US keyboard is assumed.  So this is for debugging only.

x11new/pdcscrn.c

@@ -95,6 +95,12 @@ static Font _load_font( Display *dis, const char *font_name)
 
     assert( xfont);
     XTextExtents( xfont, "A", 1, &direction, &font_ascent, &font_descent, &overall);
+#ifdef NO_LEAKS
+    if( xfont->properties)
+       free( xfont->properties);       /* frees 368 bytes */
+    if( xfont->per_char)
+       free( xfont->per_char);         /* frees 786,432 bytes */
+#endif
     XFreeFontInfo( NULL, xfont, 0);
     PDC_font_descent = font_descent;
     PDC_font_width = overall.width;