Build error when using `VS 2022`

[pavkam]

Hi,

Thanks for the great work! I'm reporting a build error I encountered recently (I haven't tried building this library in a while, so I'm unsure what triggered it).

I am trying to build the library for Windows x64. I am using:

cd wingui
nmake WIDE=Y DLL=Y CHTYPE_32=Y -f Makefile.vc

It's running in GitHub Actions (https://github.com/pavkam/sharpie/actions/runs/16748979080/job/47414187712) as I am using this lib as a prereq. for my wrapper.

Seems there's a warning which is being treated as an error:

...
 Generating Code...
	cl.exe -nologo -I.. -c -Ox -MT -W4 -WX -D_CRT_SECURE_NO_WARNINGS -DCHTYPE_32 -DPDC_DLL_BUILD  -DPDC_WIDE  ..\wingui\pdcclip.c ..\wingui\pdcdisp.c ..\wingui\pdcgetsc.c ..\wingui\pdckbd.c ..\wingui\pdcscrn.c ..\wingui\pdcsetsc.c ..\wingui\pdcutil.c 
pdcclip.c
pdcdisp.c
..\wingui\pdcdisp.c(333): error C2220: the following warning is treated as an error
..\wingui\pdcdisp.c(333): warning C4018: '>': signed/unsigned mismatch
pdcgetsc.c
pdckbd.c
pdcscrn.c
pdcsetsc.c
pdcutil.c
Generating Code...
NMAKE : fatal error U1077: 'cl.exe -nologo -I.. -c -Ox -MT -W4 -WX -D_CRT_SECURE_NO_WARNINGS -DCHTYPE_32 -DPDC_DLL_BUILD  -DPDC_WIDE  ..\wingui\pdcclip.c ..\wingui\pdcdisp.c ..\wingui\pdcgetsc.c ..\wingui\pdckbd.c ..\wingui\pdcscrn.c ..\wingui\pdcsetsc.c ..\wingui\pdcutil.c ' : return code '0x2'
...

Kinds regards,
Alex.

[GitMensch]

You may want to use the releases/latest zip instead of master, but it is nice to have that covered :-)
Can you please try to change that line (possibly with a patch in your workflow file, or if you want by forking this repo, then do the single change, then use your fork in your workflow) to

-      else if( wptr->wcLow + wptr->cGlyphs > ichar)
+      else if( wptr->wcLow + wptr->cGlyphs > (WCHAR)ichar)

? If that works, I'll commit it (if I'm faster than Bill).

[pavkam]

Thanks @GitMensch, l will give it a try and let you know

[pavkam]

Created a PR. It built on in GH actions: https://github.com/pavkam/sharpie/actions/runs/16750916798/job/47420642474

Thanks.