Open
Conversation
Collaborator
|
@juliusikkala @trexxet @jwinarske Can someone of you have a look at this PR? |
GitMensch
requested changes
Apr 9, 2026
Collaborator
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
only commenting on non-cmake parts...
Comment on lines
+401
to
+405
| # ifdef PDC_ENABLE_VISIBILITY | ||
| # define PDCEX __attribute__((visibility("default"))) extern | ||
| # else | ||
| # define PDCEX extern | ||
| # endif |
Collaborator
There was a problem hiding this comment.
that should be moved out to a separate PR
|
|
||
| endif() | ||
|
|
||
| install(FILES curses.h panel.h DESTINATION ${CMAKE_BUILD_TYPE}/include) |
Collaborator
There was a problem hiding this comment.
I think those should be in subdirectory pdcurses along with installing term.h and this should also install pdcurses.h as a wrapper with the appropriate defines and including the pdcurses/curses.h - see https://github.com/msys2/MINGW-packages/blob/86e9985a9bccf10920d28741e91394ba44741986/mingw-w64-pdcurses/PKGBUILD#L109-L116
juliusikkala
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install headers to
${CMAKE_BUILD_TYPE}/include.Set
CMAKE_INSTALL_RPATHfor demos on macos and linux. Previously the installed demos cannot be executed.Set
CMAKE_C_VISIBILITY_PRESETtohiddenon macos and linux, which prevent about 60 symbols being exported.