Skip to content

vt pdckbd (PDC_get_key): fix missing init warnings#374

Closed
GitMensch wants to merge 1 commit intomasterfrom
fix-init-get-key
Closed

vt pdckbd (PDC_get_key): fix missing init warnings#374
GitMensch wants to merge 1 commit intomasterfrom
fix-init-get-key

Conversation

@GitMensch
Copy link
Copy Markdown
Collaborator

fixes #373
some of the variables are passed as pointers to sub-functions but may not always be set - explicit initialize to fix the init-warning this results in

fixes #373 
some of the variables are passed as pointers to sub-functions but may not always be set - explicit initialize to fix the init-warning this results in
@Bill-Gray
Copy link
Copy Markdown
Owner

Good thought, but it just suppresses the warning; it doesn't fix the actual problem. The handling of window resizing on Microsoft Windows is a little flawed. We're checking the PDC_resize_occurred variable to see if the window is resized, and then calling the PDC_check_for_resize() function that sets it. This actually works, because we miss the resize at first and get it later, but it's not the right order of events.

@GitMensch
Copy link
Copy Markdown
Collaborator Author

I'll leave it to the expert :-)

If needed I possibly get back to the MSYS2 CI with PKGBUILD, but that would unlikely to be within the next 12 days.

@GitMensch GitMensch closed this Apr 4, 2026
@GitMensch GitMensch deleted the fix-init-get-key branch April 9, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VT build fails to compile in MSYS2 build

2 participants