fix: Bulk update validation now reports correct error indices (#715)

Author: george-todica

src/Http/Controllers/RepositoryUpdateBulkController.php

@@ -10,6 +10,8 @@ class RepositoryUpdateBulkController extends RepositoryController
 {
     public function __invoke(RepositoryUpdateBulkRequest $request)
     {
+        $request->repository()->allowToUpdateBulk($request);
+
         $collection = DB::transaction(function () use ($request) {
             return $request->collectInput()
                 ->each(function (array $item, int $row) use ($request) {
@@ -20,13 +22,7 @@ public function __invoke(RepositoryUpdateBulkRequest $request)
                     /** * @var Repository $repository */
                     $repository = $request->repositoryWith($model);
 
-                    return $repository
-                        ->allowToUpdateBulk($request, $item)
-                        ->updateBulk(
-                            $request,
-                            $id,
-                            $row
-                        );
+                    return $repository->updateBulk($request, $id, $row);
                 });
         });
 

src/Repositories/ValidatingTrait.php

@@ -176,7 +176,7 @@ public static function validatorForUpdateBulk(RestifyRequest $request, $resource
         })->toArray();
 
         return Validator::make(
-            [$plainPayload] ?? $request->all(),
+            $plainPayload ?? $request->all(),
             $on->getUpdatingBulkRules($request),
             $messages
         )->after(function ($validator) use ($request) {

tests/Controllers/RepositoryUpdateBulkControllerTest.php

@@ -59,4 +59,26 @@ public function test_basic_update_works(): void
         $this->assertEquals($updatedPost->title, 'Updated first title');
         $this->assertEquals($updatedPost2->title, 'Updated second title');
     }
+
+    public function test_bulk_update_validation_reports_correct_indices(): void
+    {
+        $posts = Post::factory()
+            ->count(3)
+            ->sequence(
+                ['title' => 'First title'],
+                ['title' => 'Second title'],
+                ['title' => 'Third title'],
+            )
+            ->create(['user_id' => 1]);
+
+        $response = $this->postJson(PostRepository::route('bulk/update'), [
+            ['id' => $posts[0]->id, 'title' => 'Valid updated title'],  // Valid (index 0)
+            ['id' => $posts[1]->id, 'title' => null],                   // Invalid (index 1)
+            ['id' => $posts[2]->id, 'title' => null],                   // Invalid (index 2)
+        ]);
+
+        $response->assertUnprocessable();
+        $response->assertJsonValidationErrors(['1.title', '2.title']);
+        $response->assertJsonMissingValidationErrors(['0.title']);
+    }
 }