I'm currently upgrading my project from the previous/older package to this one. I'm happy to report that the upgrade experience is quite smooth as most of the properties/functions/classes are the same.
Upon upgrading the GetBSCCountries function (from CampaignManagement), I noticed that the parameter type/class is missing. All other functions define the first parameter as "GetRequest" with a "GetResponse" as return type, except for this method. This method defines the first parameter as object without any clarification as what the object should contain.
getBSCCountries function in CampaigManagement: https://github.com/BingAds/BingAds-PHP-REST-SDK/blob/v13.0.24.1/src/Api/CampaignManagementServiceApi.php#L20081
GetBSCCountriesRequest class from previous package: https://github.com/BingAds/BingAds-PHP-SDK/blob/v13.0.27/src/V13/CampaignManagement/GetBSCCountriesRequest.php
Response class GetBSCCountriesResponse seems to be defined: https://github.com/BingAds/BingAds-PHP-REST-SDK/blob/v13.0.24.1/src/Model/CampaignManagementService/GetBSCCountriesResponse.php
The function/code seems to work fine if were to pass the following as first parameter: new stdClass(). I'm still curious if this is intentional, or if the class would be implemented in the upcoming versions?
I'm currently upgrading my project from the previous/older package to this one. I'm happy to report that the upgrade experience is quite smooth as most of the properties/functions/classes are the same.
Upon upgrading the
GetBSCCountriesfunction (from CampaignManagement), I noticed that the parameter type/class is missing. All other functions define the first parameter as "GetRequest" with a "GetResponse" as return type, except for this method. This method defines the first parameter asobjectwithout any clarification as what the object should contain.getBSCCountriesfunction in CampaigManagement: https://github.com/BingAds/BingAds-PHP-REST-SDK/blob/v13.0.24.1/src/Api/CampaignManagementServiceApi.php#L20081GetBSCCountriesRequestclass from previous package: https://github.com/BingAds/BingAds-PHP-SDK/blob/v13.0.27/src/V13/CampaignManagement/GetBSCCountriesRequest.phpResponse class
GetBSCCountriesResponseseems to be defined: https://github.com/BingAds/BingAds-PHP-REST-SDK/blob/v13.0.24.1/src/Model/CampaignManagementService/GetBSCCountriesResponse.phpThe function/code seems to work fine if were to pass the following as first parameter:
new stdClass(). I'm still curious if this is intentional, or if the class would be implemented in the upcoming versions?