From 19d6c6c3249ee9e13971c358b10328737d9fc864 Mon Sep 17 00:00:00 2001 From: Ondrej Stava Date: Fri, 23 Apr 2021 18:59:45 -0700 Subject: [PATCH] Made it easier to use the library with external zstdlib implementations (mostly in non CMake builds). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In our internal repository, we have our own version of zstdlib and introducing extra copy is both undesirable and potentially dangerous (due to ODR violations). Co-authored-by: Rémi Verschelde --- CMakeLists.txt | 2 ++ encoder/basisu_comp.cpp | 2 +- transcoder/basisu_transcoder.cpp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e2c7a1dd..1ef5655f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -180,6 +180,8 @@ target_link_libraries(examples PRIVATE basisu_encoder) if (ZSTD) target_compile_definitions(basisu PRIVATE BASISD_SUPPORT_KTX2_ZSTD=1) target_compile_definitions(examples PRIVATE BASISD_SUPPORT_KTX2_ZSTD=1) + target_include_directories(basisu PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/zstd) + target_include_directories(examples PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/zstd) else() target_compile_definitions(basisu PRIVATE BASISD_SUPPORT_KTX2_ZSTD=0) target_compile_definitions(examples PRIVATE BASISD_SUPPORT_KTX2_ZSTD=0) diff --git a/encoder/basisu_comp.cpp b/encoder/basisu_comp.cpp index 59a2a509..e9aa20f3 100644 --- a/encoder/basisu_comp.cpp +++ b/encoder/basisu_comp.cpp @@ -33,7 +33,7 @@ #endif #if BASISD_SUPPORT_KTX2_ZSTD -#include "../zstd/zstd.h" +#include #endif // Set to 1 to disable the mipPadding alignment workaround (which only seems to be needed when no key-values are written at all) diff --git a/transcoder/basisu_transcoder.cpp b/transcoder/basisu_transcoder.cpp index 0f7ca156..d7bce420 100644 --- a/transcoder/basisu_transcoder.cpp +++ b/transcoder/basisu_transcoder.cpp @@ -169,7 +169,7 @@ // If BASISD_SUPPORT_KTX2_ZSTD is 0, UASTC files compressed with Zstd cannot be loaded. #if BASISD_SUPPORT_KTX2_ZSTD // We only use two Zstd API's: ZSTD_decompress() and ZSTD_isError() - #include "../zstd/zstd.h" + #include #endif #endif