Skip to content

Commit 3b40559

Browse files
stefanhahmannclaude
andcommitted
Refactor pyramid tests as a JUnit 5 interface and split per backend
Replaces the single DefaultPyramidal5DImageDataTest with: - Pyramidal5DImageDataTestBase, a JUnit 5 test interface holding all shared parameterized tests as default methods. The single abstract method load(resource, context, preferredWidth) supplies a backend- configured Pyramidal5DImageDataImpl. - N5BackedPyramidal5DImageDataTest and ZarrJavaBackedPyramidal5DImageDataTest, two thin classes that implement the interface by constructing the matching PyramidBackend. The interface form means each concrete test class shows up as a runnable JUnit class in IntelliJ, so individual test methods can be launched directly. Both backends now run the full shared suite against the same OME-Zarr v0.4 / v0.5 fixtures. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 30e9510 commit 3b40559

3 files changed

Lines changed: 553 additions & 0 deletions

File tree

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
/*-
2+
* #%L
3+
* OME-Zarr extras for Fiji
4+
* %%
5+
* Copyright (C) 2022 - 2026 SciJava developers
6+
* %%
7+
* Redistribution and use in source and binary forms, with or without
8+
* modification, are permitted provided that the following conditions are met:
9+
*
10+
* 1. Redistributions of source code must retain the above copyright notice,
11+
* this list of conditions and the following disclaimer.
12+
* 2. Redistributions in binary form must reproduce the above copyright notice,
13+
* this list of conditions and the following disclaimer in the documentation
14+
* and/or other materials provided with the distribution.
15+
*
16+
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
17+
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
18+
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
19+
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
20+
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
21+
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
22+
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
23+
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
24+
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
25+
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
26+
* POSSIBILITY OF SUCH DAMAGE.
27+
* #L%
28+
*/
29+
package sc.fiji.ome.zarr.pyramid;
30+
31+
import java.net.URISyntaxException;
32+
import java.nio.file.Path;
33+
34+
import org.scijava.Context;
35+
36+
import sc.fiji.ome.zarr.pyramid.backend.n5.N5PyramidBackend;
37+
import sc.fiji.ome.zarr.util.ZarrTestUtils;
38+
39+
class N5BackedPyramidal5DImageDataTest implements Pyramidal5DImageDataTestBase
40+
{
41+
@Override
42+
@SuppressWarnings( { "rawtypes", "unchecked" } )
43+
public Pyramidal5DImageDataImpl< ?, ? > load( final String resource, final Context context, final Integer preferredWidth )
44+
throws URISyntaxException
45+
{
46+
Path path = ZarrTestUtils.resourcePath( resource );
47+
return new Pyramidal5DImageDataImpl<>( context, new N5PyramidBackend( path.toString(), preferredWidth ) );
48+
}
49+
}

0 commit comments

Comments
 (0)