Breaking changes for v0.3.0#29
Draft
jakobnissen wants to merge 3 commits into
Draft
Conversation
This breaking change for v0.3.0 makes more semantic sense.
Reading and writing multi-byte structs add a lot of complications which this package isn't equipped to handle, and quickly spirals into a ser/de package. For example, it requires handling: * Endianness * How to handle partial reads/write with multi-byte data * How to handle serde of types which need validation on construction * Custom serialization for certain primitives like Char ... and more. Addressing this requires a completely new and distinct API. I will spin this off to a separate package.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 93.91% 94.83% +0.91%
==========================================
Files 9 9
Lines 822 677 -145
==========================================
- Hits 772 642 -130
+ Misses 50 35 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reaches into Base internals, but I believe it might be worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.