Skip to content

Commit 35e6c11

Browse files
authored
Merge pull request #172 from Biogen-Inc/devel
Next release: `v0.2.1`
2 parents 38cb7da + 438fe6c commit 35e6c11

74 files changed

Lines changed: 1565 additions & 622 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.Rbuildignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ $run_dev.*
1919
^cran-comments\.md$
2020
^revdep$
2121
vignettes/announcing-tidycdisc-0-0-1-1.Rmd
22+
vignettes/announcing-tidycdisc-0-2-1.Rmd
2223
vignettes/Blog.Rmd
2324
vignettes/figures$
2425
vignettes/tidyCDISC.Rmd
@@ -28,3 +29,4 @@ vignettes/x0*
2829
^Meta$
2930
^CRAN-SUBMISSION$
3031
^scripts$
32+
\.sass$
Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
# Workflow derived from https://github.com/r-lib/actions/tree/master/examples
2+
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
3+
on:
4+
push:
5+
branches: [devel]
6+
pull_request:
7+
branches: [devel]
8+
9+
name: R-CMD-check
10+
11+
jobs:
12+
R-CMD-check:
13+
runs-on: ${{ matrix.config.os }}
14+
15+
name: ${{ matrix.config.os }} (${{ matrix.config.r }})
16+
17+
strategy:
18+
fail-fast: false
19+
matrix:
20+
config:
21+
- {os: macOS-latest, r: 'release'}
22+
- {os: windows-latest, r: 'release'}
23+
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
24+
- {os: ubuntu-latest, r: 'release'}
25+
- {os: ubuntu-latest, r: 'oldrel-1'}
26+
27+
env:
28+
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
29+
R_KEEP_PKG_SOURCE: yes
30+
31+
steps:
32+
- name: Install Linux system dependencies
33+
if: runner.os == 'Linux'
34+
shell: bash
35+
run: |
36+
sudo apt-get update
37+
sudo apt-get install -y libcurl4-openssl-dev
38+
sudo apt-get install -y libharfbuzz-dev
39+
sudo apt-get install -y libfribidi-dev
40+
41+
- uses: actions/checkout@v2
42+
43+
- uses: r-lib/actions/setup-pandoc@v2
44+
45+
- uses: r-lib/actions/setup-r@v2
46+
- uses: r-lib/actions/setup-renv@v2
47+
with:
48+
r-version: ${{ matrix.config.r }}
49+
http-user-agent: ${{ matrix.config.http-user-agent }}
50+
use-public-rspm: true
51+
extra-packages: rcmdcheck
52+
53+
- uses: r-lib/actions/setup-r-dependencies@v2
54+
with:
55+
extra-packages: rcmdcheck
56+
57+
# likely not needed since 'r-lib/actions/check-r-package@v2' will build
58+
# the pkg, but including it for consistency with other workflows
59+
- name: Install tidyCDISC
60+
shell: bash
61+
run: R CMD INSTALL --preclean .
62+
63+
- uses: r-lib/actions/check-r-package@v2
64+
65+
- name: Show testthat output
66+
if: always()
67+
run: find check -name 'testthat.Rout*' -exec cat '{}' \; || true
68+
shell: bash
69+
70+
- name: Upload check results
71+
if: failure()
72+
uses: actions/upload-artifact@main
73+
with:
74+
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
75+
path: check
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
push:
55
branches: [main, master]
66
pull_request:
7-
branches: [main, master, devel]
7+
branches: [main, master]
88

99
name: R-CMD-check
1010

.github/workflows/pkgdown.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,18 @@ jobs:
2828
with:
2929
use-public-rspm: true
3030

31-
- uses: r-lib/actions/setup-r-dependencies@v2
31+
- uses: r-lib/actions/setup-renv@v2
3232
with:
3333
extra-packages: any::pkgdown, local::.
3434
needs: website
3535

3636
- name: Install specific pkgdown version
3737
run: install.packages("remotes") ; remotes::install_version("pkgdown", version = "2.0.3", repos = "cran.rstudio.com", dependencies = FALSE)
3838
shell: Rscript {0}
39+
40+
- name: Install tidyCDISC
41+
shell: bash
42+
run: R CMD INSTALL --preclean .
3943

4044
- name: Build site
4145
run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE)
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# Workflow derived from https://github.com/r-lib/actions/tree/master/examples
2+
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
3+
on:
4+
push:
5+
branches: [main, master]
6+
pull_request:
7+
branches: [main, master, devel]
8+
9+
name: test-coverage
10+
11+
jobs:
12+
test-coverage:
13+
runs-on: ubuntu-latest
14+
env:
15+
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
16+
17+
steps:
18+
- uses: actions/checkout@v2
19+
20+
- uses: r-lib/actions/setup-pandoc@v2
21+
22+
- uses: r-lib/actions/setup-r@v2
23+
with:
24+
use-public-rspm: true
25+
26+
- uses: r-lib/actions/setup-renv@v2
27+
with:
28+
extra-packages: covr
29+
30+
- name: Install tidyCDISC
31+
shell: bash
32+
run: R CMD INSTALL --preclean .
33+
34+
- name: Test coverage
35+
run: covr::codecov()
36+
shell: Rscript {0}

CRAN-SUBMISSION

Lines changed: 0 additions & 3 deletions
This file was deleted.

DESCRIPTION

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: tidyCDISC
22
Title: Quick Table Generation & Exploratory Analyses on ADaM-Ish Datasets
3-
Version: 0.2.0
3+
Version: 0.2.1
44
Authors@R: c(
55
person("Aaron", "Clark", , "clark.aaronchris@gmail.com", role = c("aut", "cre"),
66
comment = c(ORCID = "0000-0002-0123-0970")),
@@ -33,7 +33,7 @@ Description: Provides users a quick exploratory dive into common
3333
modules allow for concise filtering & downloading bulk outputs into
3434
html or pdf formats to save for later.
3535
License: AGPL (>= 3)
36-
URL: https://Biogen-Inc.github.io/tidyCDISC/
36+
URL: https://github.com/Biogen-Inc/tidyCDISC/, https://Biogen-Inc.github.io/tidyCDISC/
3737
BugReports: https://github.com/Biogen-Inc/tidyCDISC/issues
3838
Depends:
3939
R (>= 2.10)
@@ -72,4 +72,4 @@ VignetteBuilder:
7272
Encoding: UTF-8
7373
Language: en-US
7474
LazyData: true
75-
RoxygenNote: 7.2.0
75+
RoxygenNote: 7.2.3

NEWS.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,31 @@
1+
# tidyCDISC (development version)
2+
- Allowed for one-element lists in heatmap axis dropdowns.
3+
4+
# tidyCDISC 0.2.1 (CRAN Release)
5+
6+
### General
7+
* Fixed bug accessing files in `app/www/` (#166)
8+
* Improved documentation
9+
* Added vignette announcing release of `v0.2.1`
10+
* Added highly visible links to Blog, YouTube, and NEWS file
11+
12+
### Table Generator
13+
* Made the html output in the app look slightly more "CSR-like" using minor formatting tricks (#181)
14+
* Arranged visits in chronological order for dropdown list found in Stat blocks (#154)
15+
* Fixed bug where wrong options were being passed on some lab tables (#169)
16+
* Fixed bug where draggable blocks were not working without inclusion of datasets with ATPT (#173)
17+
18+
### Population Explorer
19+
* Fixed bug where selected filters were not being applied when 'Apply Filters' was toggled on (#175)
20+
* Fixed bug where plots' visual appeal was destroyed when faceting variable labels were too long (#200)
21+
* Fixed bug where scatter plot wouldn't display by categorical variable with `NA` values (#192)
22+
23+
### Individual Explorer
24+
* Updated the look of the time visualization (#194)
25+
* Moved the event description to a tooltip instead of a label
26+
* Incorporated end dates (where applicable) to display ranges
27+
* Removed the auto-zoom when multiple groups were selected
28+
129

230
# tidyCDISC 0.2.0 (CRAN Release)
331

R/global.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,10 @@ utils::globalVariables(c(
123123
"id_stat", "inner_sort",
124124
"lab", "n_subgroups", "n_tot", "orig_id_rn", "orig_var_rn", "param_x",
125125
"param_y", "pt", "pval",
126-
"pval_hover", "sort_n", "v", "var", "var_rn", "where", "y"
127-
,":="
126+
"pval_hover", "sort_n", "v", "var", "var_rn", "where", "y",
127+
"type", "title"
128+
,":=",
129+
"DATE", "EVENT_TIME", "DATE_ST", "DECODE_ST", "DATE_EN", "DECODE_EN"
128130
))
129131

130132

R/mod_dataComply_fct_helpers.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,8 @@ gather_reqs <- function(input, output, session,
277277
gt::text_transform(
278278
locations = list(gt::cells_body(columns = c(not_exist_disp), rows = not_exist_disp == "X"),
279279
gt::cells_body(columns = c(missing_disp), rows = missing_disp == "X")),
280-
fn = function(X) gt::local_image(filename = "inst/app/www/red_x.png", height = 15)
280+
fn = function(X) gt::local_image(filename =
281+
app_sys('app/www', 'red_x.png'), height = 15)
281282
) %>%
282283
gt::tab_header(
283284
title = paste(ifelse(disp_type == "error", "Required:", "Optional:"),"reconcile variables below"),

0 commit comments

Comments
 (0)