Move to BDV h5#134
Open
jamesyan-git wants to merge 36 commits into
Open
Conversation
Co-authored-by: pr4deepr <13831458+pr4deepr@users.noreply.github.com>
Without this, writing by the bioio-ome-tiff writer fails.
bioio-bioformats fails with dask use: bioio-devs/bioio-bioformats#40 After fixing reading, I got a validationerror when save_dir was not set, so I set save_dir to a temporary directory as in other tests.
Author
|
@pr4deepr Hello, I think you need to approve CI. I'm just wanting to see if this passes the CICD stuff |
Author
|
I'm not sure if precommit or some vs code extension is moving stuff around in the toml, but tests should be running now. @pr4deepr would you mind approving CI again please. Thanks for your help |
Author
|
@pr4deepr pretty sure I have it all worked out now. When you have a chance, can you please run the tests again. Thanks |
Author
|
Hey @jni, mind taking a look at these failing tests. I don't think its my fault they are failing but I'm not sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #130
Relabel "h5" to "BDV h5" in interface and in enum.
Test are being flaky locally, so checking if it passes CI before pursuing further.