Ukbb mri neck to knee ozery#155
Open
michalozeryflato wants to merge 44 commits into
Open
Conversation
…eid_*_<visit>_0", since in kidney MRI there could be 2 zip files per patient
…-ml into ukbb_mri_neck_to_knee_ozery � Conflicts: � examples/fuse_examples/imaging/classification/ukbb_prostate/runner.py
…fuse-med-ml into ukbb_mri_neck_to_knee_ozery
…-ml into ukbb_mri_neck_to_knee_ozery
…to ukbb_mri_neck_to_knee_ozery � Conflicts: � examples/fuse_examples/imaging/classification/ukbb_prostate/cohort_and_label_def.py � examples/fuse_examples/imaging/classification/ukbb_prostate/conf/config_prostate_cancer.yaml � examples/fuse_examples/imaging/classification/ukbb_prostate/conf/config_prostatectomy.yaml � examples/fuse_examples/imaging/classification/ukbb_prostate/runner.py � fuseimg/datasets/ukbb_neck_to_knee.py
…fuse-med-ml into ukbb_mri_neck_to_knee_ozery
mosheraboh
requested changes
Aug 15, 2022
Collaborator
mosheraboh
left a comment
mosheraboh
left a comment
There was a problem hiding this comment.
Thanks, Itai!
I should review just the files if fuse core (under fuse dir), right?
I think that those modifications can be very useful - let's make them a bit more generic though.
| dynamic_pipeline: Optional[PipelineDefault] = None, | ||
| cacher: Optional[SamplesCacher] = None, | ||
| allow_uncached_sample_morphing: bool = False, | ||
| always_return_dict = True, |
Collaborator
There was a problem hiding this comment.
let's changed the allow_uncached_sample_morphing to mode instead of boolean.
We can have a mode that goes over all the samples to filter Nones or to split samples.
And a mode that skips it and returns whatever the pipeline generates.
See if you can come up with good names for the argument and the modes.
| if self._raise_error_key_missing: | ||
| raise Exception(f"Error: key {key} does not exist in sample {index}: {sample}") | ||
| else: | ||
| value = None |
Collaborator
There was a problem hiding this comment.
I thought that your use-case deals with a sample that is None and missing a key in one of the samples.
Cann you comment about it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.