Skip to content

Commit 4f9f85e

Browse files
author
Hauke Jürgen Mönck
committed
Fixed minor issues in trackers
LK deleted the trackpoints if tracking was done from the very first image. BST added two trackpoints when loaded initially (which are useless at startup). Renamed "foreground" to "difference"
1 parent a85ba2c commit 4f9f85e

5 files changed

Lines changed: 10 additions & 25 deletions

File tree

BioTracker/Plugin/BackgroundSubtraction/Controller/ControllerTrackedComponent.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,11 @@ void ControllerTrackedComponent::connectControllerToController()
2626
}
2727

2828
void createTrajectories(int count, TrackedTrajectory* all) {
29-
//This should be done using a factory, right?
30-
for (int i = 0; i < count; i++) {
31-
TrackedTrajectory *t = new TrackedTrajectory();
32-
t->setValid(true);
33-
TrackedElement *e = new TrackedElement(t, "n.a.", t->getId());
34-
t->add(e);
35-
all->add(t, i);
36-
}
3729
}
3830

3931
void ControllerTrackedComponent::createModel()
4032
{
4133
TrackedTrajectory *t = new TrackedTrajectory(this, "All");
42-
43-
//Add default trajectories
44-
createTrajectories(2, t);
4534
m_Model = t;
4635
}
4736

@@ -95,11 +84,6 @@ void ControllerTrackedComponent::receiveAddTrajectory(QPoint position)
9584

9685
cv::Point newPosPx = cv::Point(position.x(), position.y());
9786
cv::Point2f newPosCm = m_areaDescr->pxToCm(newPosPx);
98-
// ignore blobs outside the tracking area
99-
//if (!m_areaDescr->inTrackingArea(newPosPx)) {
100-
// qDebug() << "Created the entity outside of the tracking area!";
101-
// return;
102-
//}
10387

10488
TrackedTrajectory* newTraj = new TrackedTrajectory();
10589
TrackedElement* firstElem = new TrackedElement(newTraj, "n.a.", newTraj->getId());
@@ -133,13 +117,11 @@ void ControllerTrackedComponent::receiveMoveElement(IModelTrackedTrajectory* tra
133117
// ignore blobs outside the tracking area
134118
if (!m_areaDescr->inTrackingArea(newPosPx)) {
135119
qDebug() << "Attention! You moved the entity outside of the tracking area!";
136-
//return;
137120
}
138121

139122
FishPose newPose = FishPose(newPosCm, newPosPx, oldPose.orientation_rad(), oldPose.orientation_deg(), oldPose.width(), oldPose.height(), oldPose.getScore());
140123

141124
element->setFishPose(newPose);
142-
//qDebug() << "plugin-pos:" << position;
143125
}
144126
}
145127

BioTracker/Plugin/BackgroundSubtraction/Model/BioTrackerTrackingAlgorithm.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ void BioTrackerTrackingAlgorithm::sendSelectedImage(std::map<std::string, std::s
8787
Q_EMIT emitChangeDisplayImage(QString("Dilated"));
8888
break;
8989
case 4:
90-
sendImage = images->find(std::string("Foreground"))->second;
91-
Q_EMIT emitCvMatA(sendImage, QString("Foreground"));
92-
Q_EMIT emitChangeDisplayImage(QString("Foreground"));
90+
sendImage = images->find(std::string("Difference"))->second;
91+
Q_EMIT emitCvMatA(sendImage, QString("Difference"));
92+
Q_EMIT emitChangeDisplayImage(QString("Difference"));
9393
break;
9494
case 5:
9595
sendImage = images->find(std::string("Background"))->second;

BioTracker/Plugin/BackgroundSubtraction/Model/TrackingAlgorithm/imageProcessor/preprocessor/ImagePreProcessor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ std::map<std::string, std::shared_ptr<cv::Mat>> ImagePreProcessor::preProcess(st
193193
std::map<std::string, std::shared_ptr<cv::Mat>> all;
194194
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Greyscale"), greyMat));
195195
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Background"), m_backgroundImage));
196-
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Foreground"), m_foregroundImage));
196+
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Difference"), m_foregroundImage));
197197
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Binarized"), binarizedImage));
198198
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Eroded"), erodedImage));
199199
all.insert(std::pair<std::string, std::shared_ptr<cv::Mat>>(std::string("Dilated"), dilatedImage));

BioTracker/Plugin/BackgroundSubtraction/View/TrackerParameterView.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@
212212
</item>
213213
<item>
214214
<property name="text">
215-
<string>Foreground</string>
215+
<string>Difference</string>
216216
</property>
217217
</item>
218218
<item>

BioTracker/Plugin/LukasKanade/Model/BioTrackerTrackingAlgorithm.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,11 @@ void BioTrackerTrackingAlgorithm::doTracking(std::shared_ptr<cv::Mat> p_image, u
121121

122122
std::vector<cv::Point2f> prevPts = getPoints(_TrackedTrajectoryMajor, framenumber-1);
123123

124-
//if (!currentPointsOnlyActive.empty()) {
125-
if (_lastImage != nullptr && ! _lastImage->empty() && !prevPts.empty()){
124+
if (_lastImage == nullptr || _lastImage->empty()) {
125+
_lastImage = p_image;
126+
}
127+
128+
if (!prevPts.empty()){
126129
std::vector<float> err;
127130

128131
// calculate pyramids:

0 commit comments

Comments
 (0)