Skip to content

Avoid redundant copies by passing arguments by const reference #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vil02 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid redundant copies by passing arguments by const reference #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ntedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ str_to_upper(const std::string& str)

/* Helper for filling out the LPS array for detecting a low complexity repeat. */
void
computeLPSArray(std::string possible_repeat, int n, std::vector<int>& lps)
computeLPSArray(const std::string& possible_repeat, int n, std::vector<int>& lps)
{
int len = 0;
int i;
Expand Down Expand Up @@ -810,7 +810,7 @@ makeDeletion(

/* Returns the character at pos based on the seqNode structure. */
unsigned char
getCharacter(unsigned& pos, seqNode node, const std::string& contigSeq)
getCharacter(unsigned& pos, const seqNode& node, const std::string& contigSeq)
{
if (node.node_type == 0) {
return contigSeq.at(pos);
Expand Down
2 changes: 1 addition & 1 deletion src/ntedit_make_genome_bf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const unsigned NUM_BITS_PER_BYTE = 8;
/*
Return the genome size of the given fasta file
*/
uint64_t find_genome_size(std::vector<std::string> genome_files, int threads) {
uint64_t find_genome_size(const std::vector<std::string>& genome_files, int threads) {
uint64_t genome_size = 0;
for (const auto& genome_file : genome_files) {
btllib::SeqReader reader(
Expand Down