Use GLIDE synchronous API

Author: Jonathan-Improving

VALKEY_IMPLEMENTATION.md

@@ -1,18 +1,17 @@
 from __future__ import annotations
 
-import asyncio
 import logging
 from typing import TYPE_CHECKING, Any
 
 logger = logging.getLogger(__name__)
 
 if TYPE_CHECKING:
-    from glide import GlideClient, GlideClusterClient
+    from glide_sync import GlideClient, GlideClusterClient
 
     GlideClientType = GlideClient | GlideClusterClient
 
 
-async def get_client(valkey_url: str, **kwargs: Any) -> GlideClientType:
+def get_client(valkey_url: str, **kwargs: Any) -> GlideClientType:
     """Get a GLIDE client from the connection url.
 
     Args:
@@ -25,13 +24,13 @@ async def get_client(valkey_url: str, **kwargs: Any) -> GlideClientType:
     Example:
         ```python
         from langchain_aws.utilities.valkey import get_client
-        valkey_client = await get_client(
+        valkey_client = get_client(
             valkey_url="valkey://localhost:6379"
         )
         ```
     """
     try:
-        from glide import (
+        from glide_sync import (
             GlideClient,
             GlideClientConfiguration,
             GlideClusterClient,
@@ -40,8 +39,8 @@ async def get_client(valkey_url: str, **kwargs: Any) -> GlideClientType:
         )
     except ImportError:
         raise ImportError(
-            "Could not import valkey-glide python package. "
-            "Please install it with `pip install valkey-glide>=2.0.0`."
+            "Could not import valkey-glide-sync python package. "
+            "Please install it with `pip install valkey-glide-sync>=2.0.0`."
         )
 
     # Parse URL
@@ -51,12 +50,12 @@ async def get_client(valkey_url: str, **kwargs: Any) -> GlideClientType:
     # Try cluster first
     try:
         config = GlideClusterClientConfiguration(addresses=addresses, **kwargs)
-        client = await GlideClusterClient.create(config)
+        client = GlideClusterClient.create(config)
         return client
     except Exception:
         # Fall back to standalone
         config = GlideClientConfiguration(addresses=addresses, **kwargs)
-        client = await GlideClient.create(config)
+        client = GlideClient.create(config)
         return client
 
 

libs/aws/langchain_aws/utilities/valkey.py

@@ -1,13 +1,15 @@
 # Valkey Vector Store
 
-This module provides a vector store implementation for [Valkey](https://valkey.io/), a Redis-compatible in-memory data store that supports vector search capabilities.
+This module provides a vector store implementation for [Valkey](https://valkey.io/), a Redis-compatible in-memory data store that supports vector search capabilities. Uses the [Valkey GLIDE](https://glide.valkey.io/) synchronous client for optimal performance.
 
 ## Installation
 
 ```bash
 pip install langchain-aws[valkey]
 ```
 
+This installs `valkey-glide-sync>=2.0.0` as the client library.
+
 ## Usage
 
 ### Basic Example
@@ -64,7 +66,9 @@ vectorstore = ValkeyVectorStore.from_texts(
 - **Vector Similarity Search**: Find similar documents using cosine similarity, L2, or inner product
 - **Metadata Filtering**: Filter search results using tag, numeric, and text filters
 - **Scalable**: Built on Valkey's high-performance architecture
-- **AWS Integration**: Works seamlessly with AWS ElastiCache for Valkey
+- **AWS Integration**: Works seamlessly with AWS ElastiCache for Valkey and Amazon MemoryDB
+- **Cluster Support**: Automatic detection and support for Valkey clusters
+- **Synchronous API**: Native sync interface using Valkey GLIDE
 
 ## Connection URL Formats
 
@@ -76,10 +80,16 @@ vectorstore = ValkeyVectorStore.from_texts(
 ## Filtering
 
 ```python
-from langchain_aws.vectorstores.valkey import ValkeyFilter
+from langchain_aws.vectorstores.valkey.filters import ValkeyTag, ValkeyNum, ValkeyText
+
+# Tag filter
+filter_expr = ValkeyTag("category") == "technology"
+
+# Numeric filter
+filter_expr = ValkeyNum("year") >= 2020
 
-# Create filters
-filter_expr = (ValkeyFilter.tag("category") == "technology") & (ValkeyFilter.num("year") >= 2020)
+# Combined filters
+filter_expr = (ValkeyTag("category") == "technology") & (ValkeyNum("year") >= 2020)
 
 # Search with filter
 results = vectorstore.similarity_search(
@@ -115,11 +125,17 @@ vectorstore = ValkeyVectorStore(
 ## Requirements
 
 - Python >= 3.10
-- valkey >= 6.0.0
-- Valkey server with vector search support (Valkey 8.0+)
+- valkey-glide-sync >= 2.0.0
+- Valkey server with vector search support (Valkey 8.0+ or Redis 7.2+ with RediSearch)
 
 ## AWS Services
 
 This vector store works with:
 - [AWS ElastiCache for Valkey](https://aws.amazon.com/elasticache/)
 - [Amazon MemoryDB for Valkey](https://aws.amazon.com/memorydb/)
+
+## Additional Resources
+
+- [Valkey GLIDE Documentation](https://glide.valkey.io/)
+- [Valkey Vector Search](https://valkey.io/commands/ft.search/)
+- [LangChain VectorStores](https://python.langchain.com/docs/modules/data_connection/vectorstores/)