Skip to content

Commit 147b0b2

Browse files
Aksha1812Aksha Thakkarallenss-amazon
authored
Run CI workflows on all release branches (valkey-io#1058)
Add 1.0, 1.1, and 1.2 release branches to CI triggers so that pushes and PRs targeting them get the same CI coverage as main. Previously only main was covered, which allowed build breaks on release branches to go undetected. --------- Signed-off-by: Aksha1812 <thaakb@amazon.com> Signed-off-by: Aksha Thakkar <thaakb@amazon.com> Co-authored-by: Aksha Thakkar <thaakb@amazon.com> Co-authored-by: Allen Samuels <allenss@amazon.com>
1 parent 0f348fe commit 147b0b2

7 files changed

Lines changed: 46 additions & 46 deletions

File tree

.github/release-branches.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
main
2+
1.0
3+
1.1
4+
1.2

.github/workflows/integration_tests-asan.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
name: Integration tests ASAN
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
7-
- fulltext
4+
pull_request:
85
push:
9-
branches:
10-
- main # Optional: Run tests for direct pushes to "main"
11-
- fulltext
12-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
137

148
concurrency:
159
group: integration-tests-asan-${{ github.head_ref || github.ref }}
@@ -24,6 +18,11 @@ jobs:
2418
- name: Checkout Code
2519
uses: actions/checkout@v3
2620

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2726
# Set up Docker to build and run the container
2827
- name: Set up Docker
2928
uses: docker/setup-buildx-action@v2

.github/workflows/integration_tests.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
name: Integration tests
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
7-
- fulltext
4+
pull_request:
85
push:
9-
branches:
10-
- main # Optional: Run tests for direct pushes to "main"
11-
- fulltext
12-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
137

148
concurrency:
159
group: integration-tests-${{ github.head_ref || github.ref }}
@@ -24,6 +18,11 @@ jobs:
2418
- name: Checkout Code
2519
uses: actions/checkout@v3
2620

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2726
# Set up Docker to build and run the container
2827
- name: Set up Docker
2928
uses: docker/setup-buildx-action@v2

.github/workflows/macos.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
name: unittests-macos
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
4+
pull_request:
75
push:
8-
branches:
9-
- main # Optional: Run tests for direct pushes to "main"
10-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
117

128
concurrency:
139
group: unittests-macos-${{ github.head_ref || github.ref }}
@@ -22,6 +18,11 @@ jobs:
2218
- name: Checkout Code
2319
uses: actions/checkout@v3
2420

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2526
# Set up Docker to build and run the container
2627
- name: Build Code
2728
run: ./build.sh

.github/workflows/unittests-asan.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
name: unittests-asan
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
7-
- fulltext
4+
pull_request:
85
push:
9-
branches:
10-
- main # Optional: Run tests for direct pushes to "main"
11-
- fulltext
12-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
137

148
concurrency:
159
group: unittests-asan-${{ github.head_ref || github.ref }}
@@ -24,6 +18,11 @@ jobs:
2418
- name: Checkout Code
2519
uses: actions/checkout@v3
2620

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2726
# Set up Docker to build and run the container
2827
- name: Set up Docker
2928
uses: docker/setup-buildx-action@v2

.github/workflows/unittests-tsan.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
name: unittests-tsan
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
7-
- fulltext
4+
pull_request:
85
push:
9-
branches:
10-
- main # Optional: Run tests for direct pushes to "main"
11-
- fulltext
12-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
137

148
concurrency:
159
group: unittests-tsan-${{ github.head_ref || github.ref }}
@@ -24,6 +18,11 @@ jobs:
2418
- name: Checkout Code
2519
uses: actions/checkout@v3
2620

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2726
# Set up Docker to build and run the container
2827
- name: Set up Docker
2928
uses: docker/setup-buildx-action@v2

.github/workflows/unittests.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
name: unittests
22

33
on:
4-
pull_request: # This triggers the workflow for pull requests
5-
branches:
6-
- main # Run tests for pull requests targeting the "main" branch
7-
- fulltext
4+
pull_request:
85
push:
9-
branches:
10-
- main # Optional: Run tests for direct pushes to "main"
11-
- fulltext
12-
workflow_dispatch: # allow manual triggering
6+
workflow_dispatch:
137

148
concurrency:
159
group: unittests-${{ github.head_ref || github.ref }}
@@ -24,6 +18,11 @@ jobs:
2418
- name: Checkout Code
2519
uses: actions/checkout@v3
2620

21+
- name: Verify Branch
22+
env:
23+
BRANCH: ${{ github.base_ref || github.ref_name }}
24+
run: grep -qxF "$BRANCH" .github/release-branches.txt
25+
2726
# Set up Docker to build and run the container
2827
- name: Set up Docker
2928
uses: docker/setup-buildx-action@v2

0 commit comments

Comments
 (0)