Merge pull request #88 from afk11/master-gmp

Add Buffer::gmp()

Author: afk11

src/Buffertools/Buffer.php

@@ -74,11 +74,22 @@ public static function hex(string $hexString = '', int $byteSize = null): Buffer
      */
     public static function int($integer, $byteSize = null): BufferInterface
     {
-        if ($integer < 0) {
-            throw new \InvalidArgumentException('Negative integers not supported by Buffer::int. This could be an application error, or you should be using templates.');
+        $gmp = gmp_init($integer, 10);
+        return self::gmp($gmp, $byteSize);
+    }
+
+    /**
+     * @param \GMP $gmp
+     * @return Buffer
+     * @throws \Exception
+     */
+    public static function gmp(\GMP $gmp, $byteSize = null): BufferInterface
+    {
+        if (gmp_sign($gmp) < 0) {
+            throw new \InvalidArgumentException('Negative integers not supported. This could be an application error, or you should be using templates.');
         }
 
-        $hex = gmp_strval(gmp_init($integer, 10), 16);
+        $hex = gmp_strval($gmp, 16);
         if ((mb_strlen($hex) % 2) !== 0) {
             $hex = "0{$hex}";
         }

tests/BufferTest.php

@@ -120,6 +120,34 @@ public function testIntConstruct($int, string $expectedHex, int $size = null)
         $this->assertEquals($expectedHex, $buffer->getHex());
     }
 
+    /**
+     * @return array
+     */
+    public function getGmpVectors(): array
+    {
+        return [
+            [ gmp_init('0A', 16) ],
+            [ gmp_init('237852977508946591877284351678975096651401224047304305322504192889595623579202', 10) ],
+        ];
+    }
+
+    /**
+     * @dataProvider getGmpVectors
+     * @param \GMP $gmp
+     */
+    public function testGmpConstruction(\GMP $gmp)
+    {
+        $this->assertTrue(gmp_cmp($gmp, Buffer::gmp($gmp)->getGmp()) === 0);
+    }
+
+    public function testGmpConstructionNegative()
+    {
+        $gmp = gmp_init('-1234', 10);
+
+        $this->expectException(\InvalidArgumentException::class);
+        Buffer::gmp($gmp);
+    }
+
     public function testSlice()
     {
         $a = Buffer::hex("11000011");