OP-367 Added ECS fixes

Author: tomkalon

src/Exception/PayUResponseException.php

@@ -11,8 +11,6 @@
 namespace BitBag\SyliusPayUPlugin\Exception;
 
 use Exception;
-use Payum\Core\Exception\Http\HttpException;
-use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 
 final class PayUResponseException extends Exception
 {

tests/Behat/Context/Setup/PayUContext.php

@@ -44,7 +44,7 @@ public function __construct(
         SharedStorageInterface $sharedStorage,
         PaymentMethodRepositoryInterface $paymentMethodRepository,
         ExampleFactoryInterface $paymentMethodExampleFactory,
-        ObjectManager $paymentMethodManager
+        ObjectManager $paymentMethodManager,
     ) {
         $this->sharedStorage = $sharedStorage;
         $this->paymentMethodRepository = $paymentMethodRepository;
@@ -57,7 +57,7 @@ public function __construct(
      */
     public function theStoreHasAPaymentMethodWithACodeAndPayuCheckoutGateway(
         string $paymentMethodName,
-        string $paymentMethodCode
+        string $paymentMethodCode,
     ): void {
         $paymentMethod = $this->createPaymentMethod($paymentMethodName, $paymentMethodCode, 'PayU Checkout');
         $paymentMethod->getGatewayConfig()->setConfig(
@@ -68,7 +68,7 @@ public function theStoreHasAPaymentMethodWithACodeAndPayuCheckoutGateway(
                 'oauth_client_id' => 'CLIENT_ID',
                 'oauth_client_secret' => 'SECRET',
                 'payum.http_client' => '@sylius.payum.http_client',
-            ]
+            ],
         );
         $this->paymentMethodManager->persist($paymentMethod);
         $this->paymentMethodManager->flush();
@@ -79,7 +79,7 @@ private function createPaymentMethod(
         string $code,
         string $description = '',
         bool $addForCurrentChannel = true,
-        ?int $position = null
+        ?int $position = null,
     ): PaymentMethodInterface {
         /** @var PaymentMethodInterface $paymentMethod */
         $paymentMethod = $this->paymentMethodExampleFactory->create(
@@ -92,7 +92,7 @@ private function createPaymentMethod(
                 'enabled' => true,
                 'channels' => ($addForCurrentChannel && $this->sharedStorage->has('channel'))
                     ? [$this->sharedStorage->get('channel')] : [],
-            ]
+            ],
         );
 
         if (null !== $position) {

tests/Behat/Context/Ui/PayUContext.php

@@ -36,7 +36,7 @@ public function __construct(
         PayUApiMocker $payUApiMocker,
         ShowPageInterface $orderDetails,
         CompletePageInterface $summaryPage,
-        PayUCheckoutPageInterface $payUCheckoutPage
+        PayUCheckoutPageInterface $payUCheckoutPage,
     ) {
         $this->orderDetails = $orderDetails;
         $this->summaryPage = $summaryPage;
@@ -53,7 +53,7 @@ public function iConfirmMyOrderWithPayUPayment(): void
         $this->payUApiMocker->mockApiSuccessfulPaymentResponse(
             function () {
                 $this->summaryPage->confirmOrder();
-            }
+            },
         );
     }
 
@@ -65,7 +65,7 @@ public function iSignInToPayUAndPaySuccessfully(): void
         $this->payUApiMocker->completedPayment(
             function () {
                 $this->payUCheckoutPage->pay();
-            }
+            },
         );
     }
 
@@ -78,7 +78,7 @@ public function iCancelMyPayUPayment(): void
         $this->payUApiMocker->canceledPayment(
             function () {
                 $this->payUCheckoutPage->cancel();
-            }
+            },
         );
     }
 
@@ -90,7 +90,7 @@ public function iTryToPayAgainWithPayUPayment(): void
         $this->payUApiMocker->mockApiSuccessfulPaymentResponse(
             function () {
                 $this->orderDetails->pay();
-            }
+            },
         );
     }
 }

tests/Behat/Mocker/OpenPyUBridge.php

@@ -31,7 +31,7 @@ public function setAuthorizationData(
         string $signatureKey,
         string $posId,
         string $clientId,
-        string $clientSecret
+        string $clientSecret,
     ): void {
         $this->container
             ->get('bitbag.payu_plugin.bridge.open_payu')
@@ -40,7 +40,7 @@ public function setAuthorizationData(
                 $signatureKey,
                 $posId,
                 $clientId,
-                $clientSecret
+                $clientSecret,
             )
         ;
     }

tests/Behat/Mocker/PayUApiMocker.php

@@ -44,7 +44,7 @@ public function completedPayment(callable $action): void
             ->mockService('bitbag.payu_plugin.bridge.open_payu', OpenPayUBridgeInterface::class);
 
         $service->shouldReceive('retrieve')->andReturn(
-            $this->getDataRetrieve(OpenPayUBridge::COMPLETED_API_STATUS)
+            $this->getDataRetrieve(OpenPayUBridge::COMPLETED_API_STATUS),
         );
         $service->shouldReceive('create')->andReturn($this->createResponseSuccessfulApi());
         $service->shouldReceive('setAuthorizationData');
@@ -60,7 +60,7 @@ public function canceledPayment(callable $action): void
             ->mockService('bitbag.payu_plugin.bridge.open_payu', OpenPayUBridgeInterface::class);
 
         $service->shouldReceive('retrieve')->andReturn(
-            $this->getDataRetrieve(OpenPayUBridge::CANCELED_API_STATUS)
+            $this->getDataRetrieve(OpenPayUBridge::CANCELED_API_STATUS),
         );
         $service->shouldReceive('create')->andReturn($this->createResponseSuccessfulApi());
         $service->shouldReceive('setAuthorizationData');
@@ -70,9 +70,6 @@ public function canceledPayment(callable $action): void
         $this->mocker->unmockAll();
     }
 
-    /**
-     * @param $statusPayment
-     */
     private function getDataRetrieve($statusPayment): OpenPayU_Result
     {
         $openPayUResult = new OpenPayU_Result();

tests/Behat/Page/External/PayUCheckoutPage.php

@@ -31,15 +31,15 @@ public function __construct(Session $session, $parameters, RepositoryInterface $
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function pay()
     {
         $this->getDriver()->visit($this->findCaptureToken()->getTargetUrl());
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function cancel()
     {