Allow retry of payment for orders with status CREATED#27
Open
ahacart-adexos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem?
When a payment attempt is initiated but not completed (user leaves PSP page), the plugin sets
p24_statusand then blocks any further retries from the storefront or customer account because the code returns wheneverp24_statusis defined, regardless of its value.How to reproduce
Proposed solution
Only block access to the PSP when the payment status is set and not equal to
created.This change ensures that when p24_status === created (for example if the first attempt is incomplete), the flow continues and redirects back to the PSP for retry.