Skip to content

Commit aeef5b8

Browse files
committed
fix: restore sequence return values and correct invalid device naming
1 parent a84e316 commit aeef5b8

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

tests/create_sequence_data.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ def _generate_sequence_data(
7272
with open(sequence_root / "meta.yml", "w") as f:
7373
yaml.safe_dump(meta, f)
7474

75+
return timestamps, data, shifts
76+
7577

7678
@contextmanager
7779
def create_sequence_data(

tests/test_experiment.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -337,12 +337,13 @@ def test_experiment_skips_invalid_devices(tmp_path, override_meta, caplog):
337337
end_val = start_val + duration_val
338338

339339
# Generate random values for the invalid device as well
340-
inv_start = np.random.lognormal(mean=0.0, sigma=1.0)
341-
inv_end = inv_start + 10.0
340+
start_nonval = np.random.lognormal(mean=0.0, sigma=1.0)
341+
duration_nonval = np.random.lognormal(mean=0.0, sigma=1.0)
342+
end_nonval = start_nonval + duration_nonval
342343

343344
devices_kwargs = [
344345
{"start_time": start_val, "t_end": end_val}, # valid device
345-
{"start_time": inv_start, "t_end": inv_end}, # invalid device
346+
{"start_time": start_nonval, "t_end": end_nonval}, # invalid device
346347
]
347348

348349
with setup_test_experiment(

0 commit comments

Comments
 (0)