fix: add P2MR chain codes and remove unnecessary BitGoSignet fixture

Add chain codes 360/361 to the TypeScript chainCodes array so the WASM
chain_code_table() entries for P2MR don't crash at module load time.
Skip P2MR in utxo-lib comparison tests since utxo-lib won't add P2MR
support. Restore the bitcoinBitGoSignet -> bitcoinPublicSignet fixture
mapping that was incorrectly removed.

Ticket: BTC-3241

Author: lcovar

packages/wasm-utxo/js/fixedScriptWallet/chains.ts

@@ -8,7 +8,7 @@ import { FixedScriptWalletNamespace } from "../wasm/wasm_utxo.js";
 import type { OutputScriptType } from "./scriptType.js";
 
 /** All valid chain codes as a const tuple */
-export const chainCodes = [0, 1, 10, 11, 20, 21, 30, 31, 40, 41] as const;
+export const chainCodes = [0, 1, 10, 11, 20, 21, 30, 31, 40, 41, 360, 361] as const;
 
 /** A valid chain code value */
 export type ChainCode = (typeof chainCodes)[number];

packages/wasm-utxo/src/address/mod.rs

@@ -462,7 +462,6 @@ mod tests {
             "bitcoin.json" => vec![&BITCOIN as &dyn AddressCodec, &BITCOIN_BECH32],
             "testnet.json" => vec![&TESTNET, &TESTNET_BECH32],
             "bitcoinPublicSignet.json" => vec![&TESTNET, &TESTNET_BECH32],
-            "bitcoinBitGoSignet.json" => vec![&TESTNET, &TESTNET_BECH32],
             "bitcoincash.json" => vec![&BITCOIN_CASH],
             "bitcoincash-cashaddr.json" => vec![&BITCOIN_CASH_CASHADDR],
             "bitcoincashTestnet.json" => vec![&BITCOIN_CASH_TESTNET],

packages/wasm-utxo/test/address/utxolibCompat.ts

@@ -14,6 +14,9 @@ const __dirname = dirname(__filename);
 type Fixture = [type: string, script: string, address: string];
 
 async function getFixtures(name: string, addressFormat?: AddressFormat): Promise<Fixture[]> {
+  if (name === "bitcoinBitGoSignet") {
+    name = "bitcoinPublicSignet";
+  }
   const filename = addressFormat ? `${name}-${addressFormat}` : name;
   const fixturePath = path.join(__dirname, "..", "fixtures", "address", `${filename}.json`);
   const fixtures = await fs.readFile(fixturePath, "utf8");

packages/wasm-utxo/test/fixedScript/chains.ts

@@ -6,14 +6,17 @@ import { fixedScriptWallet } from "../../js/index.js";
 
 const { ChainCode, chainCodes } = fixedScriptWallet;
 
+// P2MR (360, 361) is wasm-only and not in utxo-lib
+const utxolibChainCodes = chainCodes.filter((c) => c !== 360 && c !== 361);
+
 describe("ChainCode", function () {
   describe("chainCodes array", function () {
     it("matches utxo-lib chainCodes", function () {
-      assert.deepStrictEqual([...chainCodes], [...utxolib.bitgo.chainCodes]);
+      assert.deepStrictEqual([...utxolibChainCodes], [...utxolib.bitgo.chainCodes]);
     });
 
     it("has expected values", function () {
-      assert.deepStrictEqual([...chainCodes], [0, 1, 10, 11, 20, 21, 30, 31, 40, 41]);
+      assert.deepStrictEqual([...chainCodes], [0, 1, 10, 11, 20, 21, 30, 31, 40, 41, 360, 361]);
     });
   });
 
@@ -69,7 +72,7 @@ describe("ChainCode", function () {
     });
 
     it("matches utxo-lib isExternalChainCode/isInternalChainCode", function () {
-      for (const code of chainCodes) {
+      for (const code of utxolibChainCodes) {
         const wasmScope = ChainCode.scope(code);
         const utxolibIsExternal = utxolib.bitgo.isExternalChainCode(code);
         const utxolibIsInternal = utxolib.bitgo.isInternalChainCode(code);
@@ -127,7 +130,7 @@ describe("ChainCode", function () {
     });
 
     it("matches utxo-lib scriptTypeForChain", function () {
-      for (const code of chainCodes) {
+      for (const code of utxolibChainCodes) {
         const wasmType = ChainCode.scriptType(code);
         const utxolibType = utxolib.bitgo.scriptTypeForChain(code);