refactor: remove utxolib dependency from fromHalfSignedLegacyTransaction tests

- Replace utxolib.Network with CoinName throughout test file
- Use wasm-utxo coinNames, isMainnet, supportsScriptType instead of utxolib equivalents
- Simplify network/coin iteration logic to work with coin name strings
- Create EXCLUDED_COINS list instead of utxolib-specific network checks
- Update createHalfSignedP2msPsbt to accept CoinName parameter
- All 13 fromHalfSignedLegacy tests still pass
- Tests now exclusively use wasm-utxo public API

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Author: OttoAllmendinger

packages/wasm-utxo/test/fixedScript/fromHalfSignedLegacyTransaction.ts

@@ -11,36 +11,38 @@
  */
 import { describe, it } from "mocha";
 import * as assert from "assert";
-import * as utxolib from "@bitgo/utxo-lib";
 import { BitGoPsbt, type HydrationUnspent } from "../../js/fixedScriptWallet/BitGoPsbt.js";
 import { ZcashBitGoPsbt } from "../../js/fixedScriptWallet/ZcashBitGoPsbt.js";
+import { supportsScriptType } from "../../js/fixedScriptWallet/index.js";
 import { ChainCode } from "../../js/fixedScriptWallet/chains.js";
 import { ECPair } from "../../js/ecpair.js";
 import { Transaction } from "../../js/transaction.js";
+import { coinNames, type CoinName, isMainnet } from "../../js/coinName.js";
 import { getDefaultWalletKeys, getKeyTriple } from "../../js/testutils/keys.js";
-import { getCoinNameForNetwork } from "../networks.js";
 
 const ZCASH_NU5_HEIGHT = 1687105;
 
 const p2msScriptTypes = ["p2sh", "p2shP2wsh", "p2wsh"] as const;
 
-function isSupportedNetwork(n: utxolib.Network): boolean {
-  return utxolib.isMainnet(n) && n !== utxolib.networks.bitcoinsv && n !== utxolib.networks.ecash;
+// Coins excluded from round-trip tests (use special handling or not supported)
+const EXCLUDED_COINS: CoinName[] = ["bsv", "bcha", "zec"];
+
+function isSupportedCoin(coin: CoinName): boolean {
+  return isMainnet(coin) && !EXCLUDED_COINS.includes(coin);
 }
 
 function createHalfSignedP2msPsbt(
-  network: utxolib.Network,
+  coinName: CoinName,
   valueOverride?: bigint,
 ): { psbt: BitGoPsbt; unspents: HydrationUnspent[] } {
-  const coinName = getCoinNameForNetwork(network);
   const rootWalletKeys = getDefaultWalletKeys();
   const [userXprv] = getKeyTriple("default");
 
   const supportedTypes = p2msScriptTypes.filter((scriptType) =>
-    utxolib.bitgo.outputScripts.isSupportedScriptType(network, scriptType),
+    supportsScriptType(coinName, scriptType),
   );
 
-  const isZcash = utxolib.getMainnet(network) === utxolib.networks.zcash;
+  const isZcash = coinName === "zec" || coinName === "tzec";
   const psbt = isZcash
     ? ZcashBitGoPsbt.createEmpty(coinName as "zec" | "tzec", rootWalletKeys, {
         version: 4,
@@ -79,7 +81,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
       // because BigInt::from(value_js).as_f64() calls JsValue::as_f64(), which
       // returns None for JS BigInt (it only works for JS Number).
       const rootWalletKeys = getDefaultWalletKeys();
-      const { psbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.bitcoin);
+      const { psbt, unspents } = createHalfSignedP2msPsbt("btc");
       const txBytes = psbt.getHalfSignedLegacyFormat();
 
       assert.doesNotThrow(() => {
@@ -93,7 +95,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
       const rootWalletKeys = getDefaultWalletKeys();
       // 21 million BTC in satoshis — the maximum possible UTXO value
       const maxSats = 21_000_000n * 100_000_000n;
-      const { psbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.bitcoin, maxSats);
+      const { psbt, unspents } = createHalfSignedP2msPsbt("btc", maxSats);
       const txBytes = psbt.getHalfSignedLegacyFormat();
 
       assert.doesNotThrow(() => {
@@ -103,19 +105,13 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
   });
 
   describe("Round-trip: getHalfSignedLegacyFormat → fromHalfSignedLegacyTransaction", function () {
-    // Zcash uses a non-standard transaction format (version 4 overwintered) that
-    // fromHalfSignedLegacyTransaction does not support; skip it here.
-    const roundTripNetworks = utxolib
-      .getNetworkList()
-      .filter(isSupportedNetwork)
-      .filter((n) => utxolib.getMainnet(n) !== utxolib.networks.zcash);
-
-    for (const network of roundTripNetworks) {
-      const networkName = utxolib.getNetworkName(network);
-      it(`${networkName}: reconstructed PSBT serializes without error`, function () {
+    // Supported coins for round-trip: all mainnet UTXO coins except special formats
+    const roundTripCoins = coinNames.filter(isSupportedCoin);
+
+    for (const coinName of roundTripCoins) {
+      it(`${coinName}: reconstructed PSBT serializes without error`, function () {
         const rootWalletKeys = getDefaultWalletKeys();
-        const coinName = getCoinNameForNetwork(network);
-        const { psbt, unspents } = createHalfSignedP2msPsbt(network);
+        const { psbt, unspents } = createHalfSignedP2msPsbt(coinName);
         const txBytes = psbt.getHalfSignedLegacyFormat();
 
         const reconstructed = BitGoPsbt.fromHalfSignedLegacyTransaction(
@@ -178,7 +174,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
       // With dynamic dispatch, fromHalfSignedLegacyTransaction now validates the transaction type
       // and rejects Zcash early with a clear error message, directing to ZcashBitGoPsbt.createEmpty().
       const rootWalletKeys = getDefaultWalletKeys();
-      const { psbt: zcashPsbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.zcash);
+      const { psbt: zcashPsbt, unspents } = createHalfSignedP2msPsbt("zec");
 
       // Step 1: Extract Zcash PSBT as legacy format
       const txBytes = zcashPsbt.getHalfSignedLegacyFormat();
@@ -197,7 +193,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
     it("should round-trip Zcash PSBT via ZcashBitGoPsbt.fromHalfSignedLegacyTransaction (with blockHeight)", function () {
       // This test verifies the round-trip: create Zcash PSBT → extract legacy format → reconstruct PSBT
       const rootWalletKeys = getDefaultWalletKeys();
-      const { psbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.zcash);
+      const { psbt, unspents } = createHalfSignedP2msPsbt("zec");
 
       // Step 1: Extract half-signed legacy format (this is what would be transmitted)
       const legacyBytes = psbt.getHalfSignedLegacyFormat();
@@ -227,7 +223,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
     it("should round-trip Zcash PSBT via ZcashBitGoPsbt.fromHalfSignedLegacyTransaction (with consensusBranchId)", function () {
       // This test verifies the round-trip with explicit consensus branch ID instead of block height
       const rootWalletKeys = getDefaultWalletKeys();
-      const { psbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.zcash);
+      const { psbt, unspents } = createHalfSignedP2msPsbt("zec");
 
       // Step 1: Extract half-signed legacy format
       const legacyBytes = psbt.getHalfSignedLegacyFormat();
@@ -258,7 +254,7 @@ describe("BitGoPsbt.fromHalfSignedLegacyTransaction", function () {
       // Dynamic dispatch enhancement: fromHalfSignedLegacyTransaction now accepts
       // either txBytes OR a pre-decoded ITransaction instance
       const rootWalletKeys = getDefaultWalletKeys();
-      const { psbt, unspents } = createHalfSignedP2msPsbt(utxolib.networks.bitcoin);
+      const { psbt, unspents } = createHalfSignedP2msPsbt("btc");
       const txBytes = psbt.getHalfSignedLegacyFormat();
 
       // Method 1: Pass raw bytes (uses dynamic dispatch internally)