chore(gha): replace deprecated app-id with client-id in audit-api-spec

The actions/create-github-app-token action deprecated the app-id input
in favour of client-id. audit-api-spec.yaml produced:
"Input app-id has been deprecated: Use client-id instead."

Rename app-id to client-id and upgrade action pin from v2 to v3.
Ref: https://github.com/actions/create-github-app-token

Ticket: AI-263
Session-Id: e92d1576-afa2-446b-b1a0-fe2efe9d2491
Task-Id: 71990ecc-1600-4249-9154-a141f1133ba4

Author: ericcrosson-bitgo

.github/workflows/audit-api-spec.yaml

@@ -218,9 +218,9 @@ jobs:
           EOF
       - name: Generate GitHub App Token
         id: generate-github-app-token
-        uses: actions/create-github-app-token@v2
+        uses: actions/create-github-app-token@v3
         with:
-          app-id: ${{ env.STATIC_ANALYSIS_BOT_APP_ID }}
+          client-id: ${{ env.STATIC_ANALYSIS_BOT_APP_ID }}
           private-key: ${{ secrets.STATIC_ANALYSIS_BOT_PRIVATE_KEY }}
           owner: bitgo
           repositories: |