chore(mbe): add dev docs for generate wallet req

Also adds walletVersion to the list of params.

Ticket: WP-5335

Author: pranavjain97

src/__tests__/api/master/eddsa.test.ts

@@ -16,7 +16,6 @@ import { EnclavedExpressClient } from '../../../api/master/clients/enclavedExpre
 import { handleEddsaSigning } from '../../../api/master/handlers/eddsa';
 import { readKey } from 'openpgp';
 
-// TODO: Re-enable once using EDDSA Custom signing fns
 describe('Eddsa Signing Handler', () => {
   let bitgo: BitGoBase;
   let wallet: Wallet;

src/api/master/handlers/generateWallet.ts

@@ -48,6 +48,7 @@ async function handleGenerateOnPremOnChainWallet(
 
   // Create wallet parameters with type assertion to allow 'onprem' subtype
   const walletParams = {
+    ...req.decoded,
     label: label,
     m: 2,
     n: 3,
@@ -157,6 +158,7 @@ async function handleGenerateOnPremMpcWallet(
   const { label, enterprise } = req.decoded;
 
   const walletParams: SupplementGenerateWalletOptions = {
+    ...req.decoded,
     label: label,
     m: 2,
     n: 3,

src/api/master/routers/masterApiSpec.ts

@@ -104,11 +104,58 @@ const GenerateWalletResponse: HttpResponse = {
 
 // Request type for /generate endpoint
 const GenerateWalletRequest = {
+  /**
+   * A human-readable label for the wallet
+   * This will be displayed in the BitGo dashboard and API responses
+   * @example "My Wallet"
+   */
   label: t.string,
+
+  /**
+   * The type of multisig wallet to create
+   * - onchain: Traditional multisig wallets using on-chain scripts
+   * - tss: Threshold Signature Scheme wallets using MPC protocols
+   * If absent, BitGo uses the default wallet type for the asset
+   * @example "tss"
+   */
   multisigType: t.union([t.literal('onchain'), t.literal('tss')]),
+
+  /**
+   * Enterprise ID - Required for Ethereum wallets
+   * Ethereum wallets can only be created under an enterprise
+   * Each enterprise has a fee address which will be used to pay for transaction fees
+   * Your enterprise ID can be seen by clicking on the "Manage Organization" link on the enterprise dropdown
+   * @example "59cd72485007a239fb00282ed480da1f"
+   * @pattern ^[0-9a-f]{32}$
+   */
   enterprise: t.string,
-  disableTransactionNotifications: t.union([t.undefined, t.boolean]),
-  isDistributedCustody: t.union([t.undefined, t.boolean]),
+
+  /**
+   * Flag for disabling wallet transaction notifications
+   * When true, BitGo will not send email/SMS notifications for wallet transactions
+   * @example false
+   */
+  disableTransactionNotifications: optional(t.boolean),
+
+  /**
+   * True, if the wallet type is a distributed-custodial
+   * If passed, you must also pass the 'enterprise' parameter
+   * Distributed custody allows multiple parties to share control of the wallet
+   * @example false
+   */
+  isDistributedCustody: optional(t.boolean),
+
+  /**
+   * Specify the wallet creation contract version used when creating an Ethereum wallet contract
+   * - 0: Old wallet creation (legacy)
+   * - 1: New wallet creation, only deployed upon receiving funds
+   * - 2: Same functionality as v1 but with NFT support
+   * - 3: MPC wallets
+   * @example 1
+   * @minimum 0
+   * @maximum 3
+   */
+  walletVersion: optional(t.number),
 };
 
 export const SendManyRequest = {
@@ -306,12 +353,56 @@ export const MasterApiSpec = apiSpec({
       path: '/api/{coin}/wallet/generate',
       request: httpRequest({
         params: {
+          /**
+           * A cryptocurrency or token ticker symbol
+           * This determines the blockchain and wallet type that will be created
+           * @example "btc"
+           * @example "eth"
+           * @example "ltc"
+           */
           coin: t.string,
         },
         body: GenerateWalletRequest,
       }),
       response: GenerateWalletResponse,
-      description: 'Generate a new wallet',
+      description: `
+# Generate a New Wallet
+
+This endpoint creates a new cryptocurrency wallet with the specified configuration. The wallet creation process involves several steps that happen automatically:
+
+## Wallet Creation Process
+
+1. **User Keychain Creation**: Creates the user keychain locally on the machine and encrypts it with the provided passphrase (skipped if userKey is provided)
+2. **Backup Keychain Creation**: Creates the backup keychain locally on the machine
+3. **Keychain Upload**: Uploads the encrypted user keychain and public backup keychain to BitGo
+4. **BitGo Key Creation**: Creates the BitGo key (and backup key if backupXpubProvider is set) on the service
+5. **Wallet Creation**: Creates the wallet on BitGo with the 3 public keys above
+
+## Important Notes
+
+### Ethereum Wallets
+- Ethereum wallets can only be created under an enterprise
+- Pass in the ID of the enterprise to associate the wallet with
+- Your enterprise ID can be seen by clicking on the "Manage Organization" link on the enterprise dropdown
+- Each enterprise has a fee address which will be used to pay for transaction fees on all Ethereum wallets in that enterprise
+- The fee address is displayed in the dashboard of the website - please fund it before creating a wallet
+
+### Subtokens
+- You cannot generate a wallet by passing in a subtoken as the coin
+- Subtokens share wallets with their parent coin and it is not possible to create a wallet specific to one token
+
+### Usage
+- This endpoint should be called through BitGo Express if used without the SDK, such as when using cURL
+- For SDK usage, the wallet creation process is handled automatically by the SDK
+
+## Query Parameters
+
+- **includeKeychains** (boolean, default: false): Include user, backup and bitgo keychains along with generated wallet
+
+## Response
+
+Returns a wallet object containing the wallet ID, label, coin type, and other configuration details. If includeKeychains is true, the response will also include the keychain information.
+      `,
     }),
   },
   'v1.wallet.sendMany': {