feat(awm): fixing test suite

Ticket: WCN-363

Author: margueriteblair

src/__tests__/api/advancedWalletManager/postMpcV2Key.test.ts

@@ -21,7 +21,8 @@ describe('postMpcV2Key', () => {
   const coin = 'hteth';
   const accessToken = 'test-token';
 
-  // sinon stubs
+  // sinon sandbox
+  const sandbox = sinon.createSandbox();
   let configStub: sinon.SinonStub;
 
   before(() => {
@@ -42,11 +43,7 @@ describe('postMpcV2Key', () => {
       clientCertAllowSelfSigned: true,
     };
 
-    // Restore any existing stub from other test suites before re-stubbing
-    if (typeof (configModule.initConfig as any).restore === 'function') {
-      (configModule.initConfig as any).restore();
-    }
-    configStub = sinon.stub(configModule, 'initConfig').returns(cfg);
+    configStub = sandbox.stub(configModule, 'initConfig').returns(cfg);
 
     // app setup
     app = advancedWalletManagerApp(cfg);
@@ -97,7 +94,7 @@ describe('postMpcV2Key', () => {
   });
 
   after(() => {
-    configStub?.restore();
+    sandbox.restore();
   });
 
   it('should be able to create a new MPC V2 wallet', async () => {

src/__tests__/api/advancedWalletManager/recoveryMpcV2.test.ts

@@ -9,7 +9,7 @@ import * as sinon from 'sinon';
 import * as configModule from '../../../initConfig';
 import { DklsTypes, DklsUtils } from '@bitgo-beta/sdk-lib-mpc';
 
-describe('recoveryMpcV2', async () => {
+describe('recoveryMpcV2', () => {
   let cfg: AdvancedWalletManagerConfig;
   let app: express.Application;
   let agent: request.SuperAgentTest;
@@ -25,31 +25,39 @@ describe('recoveryMpcV2', async () => {
   let configStub: sinon.SinonStub;
 
   // key provider nocks setup
-  const [userShare, backupShare] = await DklsUtils.generateDKGKeyShares();
-  const userKeyShare = userShare.getKeyShare().toString('base64');
-  const backupKeyShare = backupShare.getKeyShare().toString('base64');
-  const commonKeychain = DklsTypes.getCommonKeychain(userShare.getKeyShare());
-
-  const mockKeyProviderUserResponse = {
-    prv: JSON.stringify(userKeyShare),
-    pub: commonKeychain,
-    source: 'user',
-    type: 'tss',
-  };
-
-  const mockKeyProviderBackupResponse = {
-    prv: JSON.stringify(backupKeyShare),
-    pub: commonKeychain,
-    source: 'backup',
-    type: 'tss',
-  };
-  const input = {
-    txHex:
-      '02f6824268018502540be4008504a817c80083030d409443442e403d64d29c4f64065d0c1a0e8edc03d6c88801550f7dca700000823078c0',
-    pub: commonKeychain,
-  };
+  let userKeyShare: string;
+  let backupKeyShare: string;
+  let commonKeychain: string;
+  let mockKeyProviderUserResponse: { prv: string; pub: string; source: string; type: string };
+  let mockKeyProviderBackupResponse: { prv: string; pub: string; source: string; type: string };
+  let input: { txHex: string; pub: string };
 
   before(async () => {
+    const [userShare, backupShare] = await DklsUtils.generateDKGKeyShares();
+    userKeyShare = userShare.getKeyShare().toString('base64');
+    backupKeyShare = backupShare.getKeyShare().toString('base64');
+    commonKeychain = DklsTypes.getCommonKeychain(userShare.getKeyShare());
+
+    mockKeyProviderUserResponse = {
+      prv: JSON.stringify(userKeyShare),
+      pub: commonKeychain,
+      source: 'user',
+      type: 'tss',
+    };
+
+    mockKeyProviderBackupResponse = {
+      prv: JSON.stringify(backupKeyShare),
+      pub: commonKeychain,
+      source: 'backup',
+      type: 'tss',
+    };
+
+    input = {
+      txHex:
+        '02f6824268018502540be4008504a817c80083030d409443442e403d64d29c4f64065d0c1a0e8edc03d6c88801550f7dca700000823078c0',
+      pub: commonKeychain,
+    };
+
     // nock config
     nock.disableNetConnect();
     nock.enableNetConnect('127.0.0.1');
@@ -68,10 +76,6 @@ describe('recoveryMpcV2', async () => {
       recoveryMode: true,
     };
 
-    // Restore any existing stub from other test suites before re-stubbing
-    if (typeof (configModule.initConfig as any).restore === 'function') {
-      (configModule.initConfig as any).restore();
-    }
     configStub = sandbox.stub(configModule, 'initConfig').returns(cfg);
 
     // app setup

src/__tests__/api/advancedWalletManager/recoveryMusigEth.test.ts

@@ -45,10 +45,6 @@ describe('recoveryMultisigTransaction', () => {
       recoveryMode: true,
     };
 
-    // Restore any existing stub from other test suites before re-stubbing
-    if (typeof (configModule.initConfig as any).restore === 'function') {
-      (configModule.initConfig as any).restore();
-    }
     configStub = sandbox.stub(configModule, 'initConfig').returns(cfg);
 
     // app setup