feat(mbe): fix comments

Author: cpatino-intive

src/api/master/handlers/handleConsolidate.ts

@@ -1,4 +1,4 @@
-import { RequestTracer, KeyIndices } from '@bitgo/sdk-core';
+import { RequestTracer, KeyIndices, CustomSigningFunction } from '@bitgo/sdk-core';
 import logger from '../../../logger';
 import { MasterApiSpecRouteRequest } from '../routers/masterApiSpec';
 
@@ -43,7 +43,7 @@ export async function handleConsolidate(
 
   try {
     // Create custom signing function that delegates to EBE
-    const customSigningFunction = async (signParams: any) => {
+    const customSigningFunction: CustomSigningFunction = async (signParams) => {
       const signedTx = await enclavedExpressClient.signMultisig({
         txPrebuild: signParams.txPrebuild,
         source: params.source,

src/api/master/handlers/handleConsolidateUnspents.ts

@@ -1,4 +1,4 @@
-import { RequestTracer, KeyIndices } from '@bitgo/sdk-core';
+import { RequestTracer, KeyIndices, CustomSigningFunction } from '@bitgo/sdk-core';
 import logger from '../../../logger';
 import { MasterApiSpecRouteRequest } from '../routers/masterApiSpec';
 
@@ -8,9 +8,9 @@ export async function handleConsolidateUnspents(
   const enclavedExpressClient = req.enclavedExpressClient;
   const reqId = new RequestTracer();
   const bitgo = req.bitgo;
-  const baseCoin = bitgo.coin((req as any).params.coin);
-  const params = (req as any).decoded;
-  const walletId = (req as any).params.walletId;
+  const baseCoin = bitgo.coin(req.params.coin);
+  const params = req.decoded;
+  const walletId = req.params.walletId;
   const wallet = await baseCoin.wallets().get({ id: walletId, reqId });
 
   if (!wallet) {
@@ -33,7 +33,7 @@ export async function handleConsolidateUnspents(
 
   try {
     // Create custom signing function that delegates to EBE
-    const customSigningFunction = async (signParams: any) => {
+    const customSigningFunction: CustomSigningFunction = async (signParams) => {
       const signedTx = await enclavedExpressClient.signMultisig({
         txPrebuild: signParams.txPrebuild,
         source: params.source,

src/api/master/routers/masterApiSpec.ts

@@ -113,9 +113,7 @@ export const ConsolidateRequest = {
 
 // Response type for /consolidate endpoint
 const ConsolidateResponse: HttpResponse = {
-  // TODO: Get type from public types repo / Wallet Platform
   200: t.any,
-  202: t.any, // Partial success
   400: t.any, // All failed
   500: t.type({
     error: t.string,
@@ -168,9 +166,8 @@ export const ConsolidateUnspentsRequest = {
   pubkey: t.string,
   source: t.union([t.literal('user'), t.literal('backup')]),
   walletPassphrase: t.union([t.undefined, t.string]),
-  xprv: t.union([t.undefined, t.string]),
-  feeRate: t.union([t.undefined, t.union([t.string, t.number])]),
-  maxFeeRate: t.union([t.undefined, t.union([t.string, t.number])]),
+  feeRate: t.union([t.undefined, t.number]),
+  maxFeeRate: t.union([t.undefined, t.number]),
   maxFeePercentage: t.union([t.undefined, t.number]),
   feeTxConfirmTarget: t.union([t.undefined, t.number]),
   bulk: t.union([t.undefined, t.boolean]),
@@ -186,8 +183,10 @@ export const ConsolidateUnspentsRequest = {
 };
 
 const ConsolidateUnspentsResponse: HttpResponse = {
-  200: t.any,
-  202: t.any,
+  200: t.type({
+    tx: t.string,
+    txid: t.string,
+  }),
   400: t.any,
   500: t.type({
     error: t.string,