feat(ebe, mbe): add mpcv2 recovery support for eth-like coins

Ticket: WP-5168

Author: alextse-bg

package.json

@@ -25,16 +25,17 @@
     "@api-ts/response": "^2.1.0",
     "@api-ts/superagent-wrapper": "^1.3.3",
     "@api-ts/typed-express-router": "^1.1.13",
-    "@bitgo/sdk-core": "^35.3.0",
     "@bitgo-beta/sdk-lib-mpc": "8.2.1-alpha.291",
     "@bitgo/sdk-coin-ada": "^4.11.5",
     "@bitgo/sdk-coin-dot": "^4.3.5",
     "@bitgo/sdk-coin-sui": "^5.15.5",
     "@bitgo/sdk-coin-near": "^2.7.0",
     "@bitgo/sdk-coin-sol": "^4.12.5",
-    "bitgo": "^48.1.0",
     "@bitgo/abstract-utxo": "^9.21.4",
+    "@bitgo/sdk-core": "^35.3.0",
     "@bitgo/statics": "^54.6.0",
+    "@ethereumjs/tx": "^3.3.0",
+    "bitgo": "^48.1.0",
     "body-parser": "^1.20.3",
     "connect-timeout": "^1.9.0",
     "debug": "^3.1.0",

src/__tests__/api/enclaved/recoveryMpcV2.test.ts

@@ -0,0 +1,117 @@
+import { AppMode, EnclavedConfig, TlsMode } from '../../../initConfig';
+import { app as enclavedApp } from '../../../enclavedApp';
+
+import express from 'express';
+import nock from 'nock';
+import 'should';
+import * as request from 'supertest';
+import * as sinon from 'sinon';
+import * as configModule from '../../../initConfig';
+import * as bitgoSdk from '@bitgo/sdk-core';
+
+describe('recoveryMpcV2', () => {
+  let cfg: EnclavedConfig;
+  let app: express.Application;
+  let agent: request.SuperAgentTest;
+
+  let MPC: bitgoSdk.Ecdsa;
+
+  // test config
+  const kmsUrl = 'http://kms.invalid';
+  const coin = 'tsol';
+  const accessToken = 'test-token';
+
+  // sinon stubs
+  let configStub: sinon.SinonStub;
+
+  before(async () => {
+    // nock config
+    nock.disableNetConnect();
+    nock.enableNetConnect('127.0.0.1');
+
+    // app config
+    cfg = {
+      appMode: AppMode.ENCLAVED,
+      port: 0, // Let OS assign a free port
+      bind: 'localhost',
+      timeout: 60000,
+      logFile: '',
+      kmsUrl: kmsUrl,
+      tlsMode: TlsMode.DISABLED,
+      mtlsRequestCert: false,
+      allowSelfSigned: true,
+    };
+
+    configStub = sinon.stub(configModule, 'initConfig').returns(cfg);
+
+    // app setup
+    app = enclavedApp(cfg);
+    agent = request.agent(app);
+
+    MPC = new bitgoSdk.Ecdsa();
+  });
+
+  afterEach(() => {
+    nock.cleanAll();
+  });
+
+  after(() => {
+    configStub.restore();
+  });
+
+  it('should be sign a Mpc V2 Recovery', async () => {
+    const user = await MPC.keyShare(1, 2, 3);
+    const backup = await MPC.keyShare(2, 2, 3);
+    const bitgo = await MPC.keyShare(3, 2, 3);
+
+    const userSigningMaterial = {
+      uShare: user.pShare,
+      bitgoYShare: bitgo.nShares[1],
+      backupYShare: backup.nShares[1],
+    };
+
+    const backupSigningMaterial = {
+      uShare: backup.pShare,
+      bitgoYShare: bitgo.nShares[2],
+      userYShare: user.nShares[2],
+    };
+
+    const mockKmsUserResponse = {
+      prv: JSON.stringify(userSigningMaterial),
+      pub: '030030196a0a8559459029725c5494d4f7110746b27c94d3cd91ff84085ec15f50166f045f5eb1776c65ef7e9c4ffd9979b6bdc6f19e35110c8223b0bac9c0b074',
+      source: 'user',
+      type: 'tss',
+    };
+
+    const mockKmsBackupResponse = {
+      prv: JSON.stringify(backupSigningMaterial),
+      pub: '030030196a0a8559459029725c5494d4f7110746b27c94d3cd91ff84085ec15f50166f045f5eb1776c65ef7e9c4ffd9979b6bdc6f19e35110c8223b0bac9c0b074',
+      source: 'backup',
+      type: 'tss',
+    };
+
+    const input = {
+      txHex:
+        '02f839824268018502540be4008504a817c8008307a12094a94584f774b9b3e932fd4f1802f3b9aa292bd17188013fbe85edc90000823078c0808080',
+      pub: '030030196a0a8559459029725c5494d4f7110746b27c94d3cd91ff84085ec15f50166f045f5eb1776c65ef7e9c4ffd9979b6bdc6f19e35110c8223b0bac9c0b074',
+    };
+    // nocks for KMS responses
+    nock(kmsUrl).get(`/key/${input}`).query({ source: 'user' }).reply(200, mockKmsUserResponse);
+
+    nock(kmsUrl).get(`/key/${input}`).query({ source: 'backup' }).reply(200, mockKmsBackupResponse);
+
+    const signatureResponse = await agent
+      .post(`/api/${coin}/mpcv2/recovery/signature`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send(input);
+
+    signatureResponse.status.should.equal(200);
+    signatureResponse.body.should.have.property('signature');
+    signatureResponse.body.signature.should.have.property('recid');
+    signatureResponse.body.signature.should.have.property('r');
+    signatureResponse.body.signature.should.have.property('s');
+    signatureResponse.body.signature.should.have.property('y');
+    signatureResponse.body.should.have.property('txHex');
+    signatureResponse.body.txHex.should.equal(input.txHex);
+  });
+});