feat(ebe, mbe): add mpcv2 recovery support for eth-like coins

Ticket: WP-5168

Author: alextse-bg

package.json

@@ -26,15 +26,19 @@
     "@api-ts/superagent-wrapper": "^1.3.3",
     "@api-ts/typed-express-router": "^1.1.13",
     "@bitgo-beta/sdk-lib-mpc": "8.2.1-alpha.291",
+    "@bitgo/abstract-cosmos": "^11.9.7",
+    "@bitgo/abstract-eth": "^24.8.0",
     "@bitgo/abstract-utxo": "^9.21.4",
     "@bitgo/sdk-coin-ada": "^4.11.5",
+    "@bitgo/sdk-coin-atom": "^13.5.7",
     "@bitgo/sdk-coin-dot": "^4.3.5",
     "@bitgo/sdk-coin-near": "^2.7.0",
     "@bitgo/sdk-coin-sol": "^4.12.5",
     "@bitgo/sdk-coin-sui": "^5.15.5",
     "@bitgo/sdk-core": "^35.3.0",
     "@bitgo/statics": "^54.6.0",
     "@commitlint/config-conventional": "^19.8.1",
+    "@ethereumjs/tx": "^3.3.0",
     "bitgo": "^48.1.0",
     "body-parser": "^1.20.3",
     "connect-timeout": "^1.9.0",

src/__tests__/api/enclaved/recoveryMpcV2.test.ts

@@ -0,0 +1,188 @@
+import { AppMode, EnclavedConfig, TlsMode } from '../../../initConfig';
+import { app as enclavedApp } from '../../../enclavedApp';
+
+import express from 'express';
+import nock from 'nock';
+import 'should';
+import * as request from 'supertest';
+import * as sinon from 'sinon';
+import * as configModule from '../../../initConfig';
+import { DklsTypes, DklsUtils } from '@bitgo-beta/sdk-lib-mpc';
+
+// atom, cordao, sei, thor, : integration test and unit test, refactor unit test for repeated code use TODO
+
+describe('recoveryMpcV2', async () => {
+  let cfg: EnclavedConfig;
+  let app: express.Application;
+  let agent: request.SuperAgentTest;
+
+  // test config
+  const kmsUrl = 'http://kms.invalid';
+  const ethLikeCoin = 'hteth';
+  const nonEcdsaCoin = 'btc';
+  const notImplementedCoin = '';
+  const accessToken = 'test-token';
+
+  // sinon stubs
+  let configStub: sinon.SinonStub;
+
+  // kms nocks setup
+  const [userShare, backupShare] = await DklsUtils.generateDKGKeyShares();
+  const userKeyShare = userShare.getKeyShare().toString('base64');
+  const backupKeyShare = backupShare.getKeyShare().toString('base64');
+  const commonKeychain = DklsTypes.getCommonKeychain(userShare.getKeyShare());
+
+  const mockKmsUserResponse = {
+    prv: JSON.stringify(userKeyShare),
+    pub: commonKeychain,
+    source: 'user',
+    type: 'tss',
+  };
+
+  const mockKmsBackupResponse = {
+    prv: JSON.stringify(backupKeyShare),
+    pub: commonKeychain,
+    source: 'backup',
+    type: 'tss',
+  };
+
+  before(async () => {
+    // nock config
+    nock.disableNetConnect();
+    nock.enableNetConnect('127.0.0.1');
+
+    // app config
+    cfg = {
+      appMode: AppMode.ENCLAVED,
+      port: 0, // Let OS assign a free port
+      bind: 'localhost',
+      timeout: 60000,
+      logFile: '',
+      kmsUrl: kmsUrl,
+      tlsMode: TlsMode.DISABLED,
+      mtlsRequestCert: false,
+      allowSelfSigned: true,
+    };
+
+    configStub = sinon.stub(configModule, 'initConfig').returns(cfg);
+
+    // app setup
+    app = enclavedApp(cfg);
+    agent = request.agent(app);
+  });
+
+  afterEach(() => {
+    nock.cleanAll();
+  });
+
+  after(() => {
+    configStub.restore();
+  });
+
+  // happy path test
+  it('should be sign a Mpc V2 Recovery', async () => {
+    const input = {
+      txHex:
+        '02f6824268018502540be4008504a817c80083030d409443442e403d64d29c4f64065d0c1a0e8edc03d6c88801550f7dca700000823078c0',
+      pub: commonKeychain,
+    };
+    // nocks for KMS responses
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'user', useLocalEncipherment: false })
+      .reply(200, mockKmsUserResponse);
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'backup', useLocalEncipherment: false })
+      .reply(200, mockKmsBackupResponse);
+
+    const signatureResponse = await agent
+      .post(`/api/${ethLikeCoin}/mpcv2/recovery`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send(input);
+
+    signatureResponse.status.should.equal(200);
+    signatureResponse.body.should.have.property('txHex');
+    signatureResponse.body.txHex.should.equal(input.txHex);
+    
+    signatureResponse.body.should.have.property('stringifiedSignature');
+    const signature = JSON.parse(signatureResponse.body.stringifiedSignature);
+    signature.should.have.property('recid');
+    signature.should.have.property('r');
+    signature.should.have.property('s');
+    signature.should.have.property('y');
+  });
+
+  // failure test cases
+  it('should throw 400 Bad Request if coin is not ECDSA', async () => {
+    const input = {
+      txHex:
+        '02f6824268018502540be4008504a817c80083030d409443442e403d64d29c4f64065d0c1a0e8edc03d6c88801550f7dca700000823078c0',
+      pub: commonKeychain,
+    };
+
+    // non-ecdsa coin used in mpc v2 recovery
+    const signatureResponse = await agent
+      .post(`/api/${nonEcdsaCoin}/mpcv2/recovery`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send(input);
+
+    signatureResponse.status.should.equal(400);
+    signatureResponse.body.should.have.property('error');
+    signatureResponse.body.error.should.equal(`Enclave does not support Mpc V2 recovery for coin family: ${nonEcdsaCoin}`);
+  })
+
+  it('should throw 501 Not Implemented if coin is not implemented', async () => {
+    const input = {
+      txHex:
+        '02f6824268018502540be4008504a817c80083030d409443442e403d64d29c4f64065d0c1a0e8edc03d6c88801550f7dca700000823078c0',
+      pub: commonKeychain,
+    };
+
+    // nocks for KMS responses
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'user', useLocalEncipherment: false })
+      .reply(200, mockKmsUserResponse);
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'backup', useLocalEncipherment: false })
+      .reply(200, mockKmsBackupResponse);
+
+    // not implemented coin used in mpc v2 recovery
+    const signatureResponse = await agent
+      .post(`/api/${notImplementedCoin}/mpcv2/recovery`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send(input);
+
+    signatureResponse.status.should.equal(501);
+    signatureResponse.body.should.have.property('error');
+    signatureResponse.body.error.should.equal(`Enclave does not support Mpc V2 recovery for coin family: ${notImplementedCoin}`);
+  });
+
+  it('should throw 400 Bad Request if failed to construct eth transaction from message hex', async () => {
+    const input = {
+      txHex: 'invalid-hex',
+      pub: commonKeychain,
+    };
+
+    // nocks for KMS responses
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'user', useLocalEncipherment: false })
+      .reply(200, mockKmsUserResponse);
+    nock(kmsUrl)
+      .get(`/key/${input.pub}`)
+      .query({ source: 'backup', useLocalEncipherment: false })
+      .reply(200, mockKmsBackupResponse);
+
+    const signatureResponse = await agent
+      .post(`/api/${ethLikeCoin}/mpcv2/recovery`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send(input);
+
+    signatureResponse.status.should.equal(400);
+    signatureResponse.body.should.have.property('error');
+    signatureResponse.body.error.should.startWith('Failed to construct eth transaction from message hex');
+  });
+});