feat: behavior adjustments based on reviews

Author: mtexeira-simtlix

src/api/enclaved/recoveryMultisigTransaction.ts

@@ -28,8 +28,6 @@ export async function recoveryMultisigTransaction(
   if (coin.isEVM()) {
     // Every recovery method on every coin family varies one from another so we need to ensure with a guard.
     if (isEthLikeCoin(coin)) {
-      // TODO: populate coinSpecificParams with things like replayProtectionOptions
-      // coinSpecificParams type could be "recoverOptions"
       try {
         const halfSignedTx = await coin.signTransaction({
           isLastSignature: false,

src/masterBitgoExpress/enclavedExpressClient.ts

@@ -39,7 +39,6 @@ interface RecoveryMultisigOptions {
     bitgoPub?: string;
     ignoreAddressTypes?: string[];
   };
-  // recoveryDestinationAddress: string;
 }
 
 export class EnclavedExpressClient {
@@ -149,11 +148,11 @@ export class EnclavedExpressClient {
   }
 
   /**
-   * Recovery a multisig transaction
+   * Recover a multisig transaction
    */
   async recoveryMultisig(params: RecoveryMultisigOptions): Promise<SignedTransaction> {
     if (!this.coin) {
-      throw new Error('Coin must be specified to recovery a multisig');
+      throw new Error('Coin must be specified to recover a multisig');
     }
 
     try {

src/masterBitgoExpress/recoveryWallet.ts

@@ -1,25 +1,13 @@
-import assert from 'assert';
 import { MethodNotImplementedError } from 'bitgo';
 import { isEthLikeCoin } from '../shared/coinUtils';
-import { isMasterExpressConfig } from '../types';
-import { createEnclavedExpressClient } from './enclavedExpressClient';
 import { MasterApiSpecRouteRequest } from './routers/masterApiSpec';
 
 export async function handleRecoveryWalletOnPrem(
   req: MasterApiSpecRouteRequest<'v1.wallet.recovery', 'post'>,
 ) {
   const bitgo = req.bitgo;
   const coin = req.decoded.coin;
-  assert(
-    isMasterExpressConfig(req.config),
-    'Expected req.config to be of type MasterExpressConfig',
-  );
-  const enclavedExpressClient = createEnclavedExpressClient(req.config, coin);
-  if (!enclavedExpressClient) {
-    throw new Error(
-      'Enclaved express client not configured - enclaved express features will be disabled',
-    );
-  }
+  const enclavedExpressClient = req.enclavedExpressClient;
 
   const {
     userPub,
@@ -53,7 +41,6 @@ export async function handleRecoveryWalletOnPrem(
         unsignedSweepPrebuildTx,
         coinSpecificParams,
         walletContractAddress,
-        // recoveryDestinationAddress,
       });
 
       return fullSignedRecoveryTx;

src/shared/coinUtils.ts

@@ -34,7 +34,6 @@ export function isUtxoCoin(coin: BaseCoin): coin is AbstractUtxoCoin {
     isFamily(coin, CoinFamily.BCH) ||
     isFamily(coin, CoinFamily.ZEC) ||
     isFamily(coin, CoinFamily.DASH) ||
-    isFamily(coin, CoinFamily.DASH) ||
     isFamily(coin, CoinFamily.BTG);
 
   return isBtc || isBtcLike;