Merge pull request #44 from BitGo/WP-00000-ebe-eddsa-follow-up

chore: address follow up comments

Author: mohammadalfaiyazbitgo

src/api/enclaved/handlers/signMpcTransaction.ts

@@ -70,14 +70,6 @@ interface EddsaSigningParams {
 export async function signMpcTransaction(req: EnclavedApiSpecRouteRequest<'v1.mpc.sign', 'post'>) {
   const { source, pub, coin, encryptedDataKey, shareType } = req.decoded;
 
-  if (!source || !pub) {
-    throw new Error('Source and public key are required for MPC signing');
-  }
-
-  if (!shareType) {
-    throw new Error('Share type is required for MPC signing');
-  }
-
   const bitgo = req.bitgo;
   const coinInstance = bitgo.coin(coin);
 
@@ -147,9 +139,6 @@ async function handleEddsaSigning(
 
   switch (shareType.toLowerCase()) {
     case ShareType.Commitment: {
-      if (!txRequest) {
-        throw new Error('txRequest is required for commitment share generation');
-      }
       if (!bitgoGpgPubKey) {
         throw new Error('bitgoGpgPubKey is required for commitment share generation');
       }
@@ -166,9 +155,6 @@ async function handleEddsaSigning(
       };
     }
     case ShareType.R: {
-      if (!txRequest) {
-        throw new Error('txRequest is required for R share generation');
-      }
       if (!encryptedUserToBitgoRShare) {
         throw new Error('encryptedUserToBitgoRShare is required for R share generation');
       }
@@ -186,9 +172,6 @@ async function handleEddsaSigning(
       return await eddsaUtils.createRShareFromTxRequest(rShareParams);
     }
     case ShareType.G: {
-      if (!txRequest) {
-        throw new Error('txRequest is required for G share generation');
-      }
       if (!bitgoToUserRShare) {
         throw new Error('bitgoToUserRShare is required for G share generation');
       }

src/enclavedBitgoExpress/routers/enclavedApiSpec.ts

@@ -85,7 +85,7 @@ const RecoveryMultisigResponse: HttpResponse = {
 const SignMpcRequest = {
   source: t.string,
   pub: t.string,
-  txRequest: t.union([t.undefined, t.any]),
+  txRequest: t.any,
   bitgoToUserRShare: t.union([t.undefined, t.any]),
   userToBitgoRShare: t.union([t.undefined, t.any]),
   encryptedUserToBitgoRShare: t.union([t.undefined, t.any]),

src/kms/kmsClient.ts

@@ -93,7 +93,7 @@ export class KmsClient {
         .set('x-api-key', 'abc')
         .send(params);
     } catch (error: any) {
-      console.log('Error generating data key from KMS', error);
+      debugLogger('Error generating data key from KMS', error);
       throw error;
     }
 
@@ -120,7 +120,7 @@ export class KmsClient {
         .set('x-api-key', 'abc')
         .send(params);
     } catch (error: any) {
-      console.log('Error decrypting data key from KMS', error);
+      debugLogger('Error decrypting data key from KMS', error);
       throw error;
     }