feat: seperate client/server mtls configs #107
Merged
Merged
Conversation
pranavjain97
force-pushed
the
WP-5523-seperate-mtls-configs
branch
8 times, most recently
from
a8d2f81 to
419044d
Compare
pranavjain97
force-pushed
the
WP-5523-seperate-mtls-configs
branch
from
419044d to
c09c6bf
Compare
pranavjain97
force-pushed
the
WP-5523-seperate-mtls-configs
branch
from
c09c6bf to
8a53d89
Compare
cpatino-intive
approved these changes
Aug 8, 2025
| ` • Allow Self-Signed AWM Server Certiicates: ${config.awmServerCertAllowSelfSigned}`, | ||
| ); | ||
| } | ||
| logger.info('========================'); |
Contributor
There was a problem hiding this comment.
should remove this logger.
Contributor
Author
There was a problem hiding this comment.
i intentionally added these for clearer startup logs for both MBE/AWM
| ` • Allow Self-Signed KMS Server Certificates: ${config.kmsServerCertAllowSelfSigned}`, | ||
| ); | ||
| } | ||
| logger.info('========================'); |
Contributor
There was a problem hiding this comment.
should remove this logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5523