Skip to content

chore(mbe, awm): update docker build/docker compose#113

Merged
pranavjain97 merged 1 commit into
masterfrom
WP-00000-fix-docker-build-cmd
Aug 13, 2025
Merged

chore(mbe, awm): update docker build/docker compose#113
pranavjain97 merged 1 commit into
masterfrom
WP-00000-fix-docker-build-cmd

Conversation

@pranavjain97

Copy link
Copy Markdown
Contributor

Ticket: WP-00000

@pranavjain97 pranavjain97 force-pushed the WP-00000-fix-docker-build-cmd branch from fdeaee8 to ad1913b Compare August 11, 2025 20:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Docker build and Docker Compose configuration for the BitGo on-premises applications. The changes aim to improve the container setup by separating build commands for different services and enhancing the Docker Compose configuration with comprehensive environment variable documentation.

  • Split the single container build command into separate commands for master-bitgo-express and advanced-wallet-manager
  • Updated Docker Compose configuration with comprehensive environment variable documentation and better organization
  • Updated README documentation to reflect the new build commands and container names

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Split container build script into separate commands for master-bitgo-express and advanced-wallet-manager
docker-compose.yml Enhanced environment variable configuration with detailed comments and reorganized settings
README.md Updated documentation to reflect new build commands and container names

Comment thread docker-compose.yml
- KMS_URL=http://172.20.0.1:3000

# Network settings
- ADVANCED_WALLET_MANAGER_PORT=3080

Copilot AI Aug 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port configuration is inconsistent with the package.json build arguments. The package.json shows PORT=3081 for master-bitgo-express but PORT=3080 for advanced-wallet-manager, while this Docker Compose shows ADVANCED_WALLET_MANAGER_PORT=3080. This could cause confusion about which service uses which port.

Suggested change
- ADVANCED_WALLET_MANAGER_PORT=3080
- PORT=3080

Copilot uses AI. Check for mistakes.
Comment thread docker-compose.yml
- APP_MODE=master-express

# Network settings
- MASTER_EXPRESS_PORT=3081

Copilot AI Aug 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the port configuration approach. The package.json build args show PORT=3081 for master-bitgo-express, but the Docker Compose uses MASTER_EXPRESS_PORT=3081. Consider using consistent environment variable naming patterns across both services.

Suggested change
- MASTER_EXPRESS_PORT=3081
- PORT=3081

Copilot uses AI. Check for mistakes.
@pranavjain97 pranavjain97 force-pushed the WP-00000-fix-docker-build-cmd branch from ad1913b to ddee1e2 Compare August 12, 2025 21:54
@pranavjain97 pranavjain97 merged commit 484601a into master Aug 13, 2025
4 checks passed
@pranavjain97 pranavjain97 deleted the WP-00000-fix-docker-build-cmd branch August 13, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants