chore(mbe, awm): update docker build/docker compose#113
Conversation
pranavjain97
force-pushed
the
WP-00000-fix-docker-build-cmd
branch
from
fdeaee8 to
ad1913b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker build and Docker Compose configuration for the BitGo on-premises applications. The changes aim to improve the container setup by separating build commands for different services and enhancing the Docker Compose configuration with comprehensive environment variable documentation.
- Split the single container build command into separate commands for master-bitgo-express and advanced-wallet-manager
- Updated Docker Compose configuration with comprehensive environment variable documentation and better organization
- Updated README documentation to reflect the new build commands and container names
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Split container build script into separate commands for master-bitgo-express and advanced-wallet-manager |
| docker-compose.yml | Enhanced environment variable configuration with detailed comments and reorganized settings |
| README.md | Updated documentation to reflect new build commands and container names |
| - KMS_URL=http://172.20.0.1:3000 | ||
|
|
||
| # Network settings | ||
| - ADVANCED_WALLET_MANAGER_PORT=3080 |
There was a problem hiding this comment.
The port configuration is inconsistent with the package.json build arguments. The package.json shows PORT=3081 for master-bitgo-express but PORT=3080 for advanced-wallet-manager, while this Docker Compose shows ADVANCED_WALLET_MANAGER_PORT=3080. This could cause confusion about which service uses which port.
| - ADVANCED_WALLET_MANAGER_PORT=3080 | |
| - PORT=3080 |
| - APP_MODE=master-express | ||
|
|
||
| # Network settings | ||
| - MASTER_EXPRESS_PORT=3081 |
There was a problem hiding this comment.
There's an inconsistency in the port configuration approach. The package.json build args show PORT=3081 for master-bitgo-express, but the Docker Compose uses MASTER_EXPRESS_PORT=3081. Consider using consistent environment variable naming patterns across both services.
| - MASTER_EXPRESS_PORT=3081 | |
| - PORT=3081 |
pranavjain97
force-pushed
the
WP-00000-fix-docker-build-cmd
branch
from
ad1913b to
ddee1e2
Compare
Ticket: WP-00000