-
Notifications
You must be signed in to change notification settings - Fork 1
chore(mbe, awm): update docker build/docker compose #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,51 +3,116 @@ version: '3.8' | |||||
| services: | ||||||
| # Service for advanced-wallet-manager (AWM) | ||||||
| advanced-wallet-manager: | ||||||
| build: . # Build from the Dockerfile inside the repo | ||||||
| build: . # Build from the Dockerfile inside the repo | ||||||
| container_name: advanced-wallet-manager | ||||||
| networks: | ||||||
| - my-internal-network # Only part of the internal network | ||||||
| - my-internal-network # Only part of the internal network | ||||||
| environment: | ||||||
| - ADVANCED_WALLET_MANAGER_PORT=3081 | ||||||
| - TLS_MODE=disabled | ||||||
| - ALLOW_SELF_SIGNED=true | ||||||
| - MTLS_REQUEST_CERT=false | ||||||
| - RECOVERY_MODE=true | ||||||
| # Application mode (required) | ||||||
| - APP_MODE=advanced-wallet-manager | ||||||
| - KMS_URL=http://172.20.0.1:3000 | ||||||
|
|
||||||
| # Network settings | ||||||
| - ADVANCED_WALLET_MANAGER_PORT=3080 | ||||||
| - BIND=0.0.0.0 | ||||||
| - TIMEOUT=305000 | ||||||
| - KEEP_ALIVE_TIMEOUT=65000 | ||||||
| - HEADERS_TIMEOUT=66000 | ||||||
|
|
||||||
| # TLS settings | ||||||
| - TLS_MODE=disabled | ||||||
| - CLIENT_CERT_ALLOW_SELF_SIGNED=true | ||||||
|
|
||||||
| # KMS settings (required) | ||||||
| - KMS_URL=http://172.20.0.1:3000 # UPDATE TO YOUR OWN KMS URL | ||||||
| - KMS_SERVER_CERT_ALLOW_SELF_SIGNED=true | ||||||
|
|
||||||
| # Optional KMS TLS settings (uncomment if using mTLS with KMS) | ||||||
| # - KMS_SERVER_CA_CERT_PATH=/path/to/kms-ca-cert.pem | ||||||
| # - KMS_CLIENT_TLS_KEY_PATH=/path/to/kms-client-key.pem | ||||||
| # - KMS_CLIENT_TLS_CERT_PATH=/path/to/kms-client-cert.pem | ||||||
| # - KMS_CLIENT_TLS_KEY=<key-content> | ||||||
| # - KMS_CLIENT_TLS_CERT=<cert-content> | ||||||
|
|
||||||
| # Optional server TLS settings (uncomment if using mTLS) | ||||||
| # - SERVER_TLS_KEY_PATH=/path/to/server-key.pem | ||||||
| # - SERVER_TLS_CERT_PATH=/path/to/server-cert.pem | ||||||
| # - SERVER_TLS_KEY=<key-content> | ||||||
| # - SERVER_TLS_CERT=<cert-content> | ||||||
| # - MTLS_ALLOWED_CLIENT_FINGERPRINTS=ABC123,DEF456 | ||||||
|
|
||||||
| # Logging and debug | ||||||
| - HTTP_LOGFILE=logs/http-access.log | ||||||
| - RECOVERY_MODE=true | ||||||
| - NODE_ENV=production | ||||||
| - LOG_LEVEL=info | ||||||
| restart: always | ||||||
| ports: [] # No public ports exposed | ||||||
| ports: [] # No public ports exposed | ||||||
| volumes: | ||||||
| - ./logs:/app/logs # Mount logs directory | ||||||
|
|
||||||
| # Service for master-bitgo-express (MBE) - both internal and publicly accessible | ||||||
| master-bitgo-express: | ||||||
| build: . # Build from the Dockerfile inside the repo | ||||||
| build: . # Build from the Dockerfile inside the repo | ||||||
| container_name: master-bitgo-express | ||||||
| networks: | ||||||
| - my-internal-network # Connect to the internal network for internal communication | ||||||
| - my-public-network # Connect to the public network for external access | ||||||
| - my-internal-network # Connect to the internal network for internal communication | ||||||
| - my-public-network # Connect to the public network for external access | ||||||
| environment: | ||||||
| # Application mode (required) | ||||||
| - APP_MODE=master-express | ||||||
|
|
||||||
| # Network settings | ||||||
| - MASTER_EXPRESS_PORT=3081 | ||||||
|
||||||
| - MASTER_EXPRESS_PORT=3081 | |
| - PORT=3081 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port configuration is inconsistent with the package.json build arguments. The package.json shows PORT=3081 for master-bitgo-express but PORT=3080 for advanced-wallet-manager, while this Docker Compose shows ADVANCED_WALLET_MANAGER_PORT=3080. This could cause confusion about which service uses which port.