feat(mbe): add sendMany api signing with ebe#15
Merged
Conversation
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
2 times, most recently
from
2a1d6f6 to
6bcd18e
Compare
pranavjain97
changed the title
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
from
6bcd18e to
1072f3a
Compare
alextse-bg
reviewed
Jun 10, 2025
|
|
||
| try { | ||
| const res = await this.configureRequest( | ||
| superagent.post(`${this.baseUrl}/api/${this.coin}/signMultisig`).type('json'), |
Contributor
There was a problem hiding this comment.
superagent.post(${this.baseUrl}/api/${this.coin}/multisig/sign).type('json'),
| ...prebuildParams, | ||
| reqId, | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
do we not need to verify the transaction here?
Contributor
Author
There was a problem hiding this comment.
yup added verification
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
from
1072f3a to
f7eff3b
Compare
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
2 times, most recently
from
b618251 to
0817b25
Compare
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
from
0817b25 to
567edba
Compare
pranavjain97
force-pushed
the
WP-4634-multisig-signing-mbe
branch
from
567edba to
7ab0f9c
Compare
alextse-bg
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-4634