chore: improve README intro#159
Merged
Merged
Conversation
vmccarty
reviewed
Nov 24, 2025
vmccarty
reviewed
Nov 24, 2025
| - **KMS API Implementation** - Advanced Wallet Manager requires a KMS API for secure key operations. For example: | ||
| - [AWS HSM Implementation](./demo-kms-script/aws-interface.md) | ||
| - [Dinamo HSM Implementation](./demo-kms-script/dinamo-interface.md) | ||
| - **KMS API Implementation** - You must implement the KMS API interface to connect your KMS/HSM to the Advanced Wallet Manager. The interface specification is provided by BitGo. Reference implementations are available to guide your integration: |
Contributor
There was a problem hiding this comment.
Suggested change
| - **KMS API Implementation** - You must implement the KMS API interface to connect your KMS/HSM to the Advanced Wallet Manager. The interface specification is provided by BitGo. Reference implementations are available to guide your integration: | |
| - **KMS API Implementation** - You must implement the KMS API interface to connect your KMS/HSM to the Advanced Wallet Manager. BitGo provides a specification for the interface and the following example implementations: |
Contributor
There was a problem hiding this comment.
Where does BitGo provide the spec?
Contributor
Author
There was a problem hiding this comment.
good catch, i thought we already included it in the repo but we didn't
adding it separately and will link that here 👍🏼
vmccarty
reviewed
Nov 24, 2025
pranavjain97
force-pushed
the
WP-6770-update-readme
branch
from
3a0c9b6 to
ea28451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-6770